Only display derived parameters on normal GUI complexity #910
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the parameter editor table to conditionally hide forced and derived parameters when the GUI is set to "simple" complexity mode. The change aims to reduce clutter for users who prefer a simplified interface, though the PR description notes concerns about hiding parameter changes from users.
Key changes:
- Add filtering logic to skip forced and derived parameters in simple GUI mode
- Maintain upload functionality for all parameters regardless of display status
- Update row counting to reflect only displayed parameters
| param_metadata = self.local_filesystem.doc_dict.get(param_name, {}) | ||
| param_default = self.local_filesystem.param_default_dict.get(param_name, None) | ||
| doc_tooltip = param_metadata.get( | ||
| "doc_tooltip", _("No documentation available in apm.pdef.xml for this parameter") | ||
| ) |
There was a problem hiding this comment.
These lines appear to be creating variables that are not used in the visible code. If these variables are needed for the _create_column_widgets method, they should be passed as parameters or used directly within that method call to avoid creating unused local variables.
| param_metadata = self.local_filesystem.doc_dict.get(param_name, {}) | |
| param_default = self.local_filesystem.param_default_dict.get(param_name, None) | |
| doc_tooltip = param_metadata.get( | |
| "doc_tooltip", _("No documentation available in apm.pdef.xml for this parameter") | |
| ) |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 2 files ±0 2 suites ±0 1m 40s ⏱️ -7s For more details on these failures, see this check. Results for commit 623b908. ± Comparison against base commit c0d7d34. |
I'm not sure this makes sense because it hides changes from the users and we do not want to do changes behind the users back.
But if they really want it, here it is.