Skip to content

Commit 8f34226

Browse files
committed
Fix possible null pointer write or memory corruption during CDX read
1 parent c1fe609 commit 8f34226

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/warc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,16 +1508,14 @@ warc_process_cdx_line (char *lineptr, int field_num_original_url,
15081508
bytes. */
15091509
idx_t checksum_l;
15101510
char * checksum_v;
1511-
char *digest;
15121511
base32_decode_alloc (checksum, strlen (checksum), &checksum_v,
15131512
&checksum_l);
15141513
xfree (checksum);
15151514

15161515
if (checksum_v != NULL && checksum_l == SHA1_DIGEST_SIZE)
15171516
{
15181517
/* This is a valid line with a valid checksum. */
1519-
memcpy (digest, checksum_v, SHA1_DIGEST_SIZE);
1520-
store_warc_record(original_url, NULL, record_id, digest);
1518+
store_warc_record(original_url, NULL, record_id, checksum_v);
15211519
xfree (checksum_v);
15221520
}
15231521
else

0 commit comments

Comments
 (0)