test: fix tests to work with new encoding-safe subprocess calls

- Update all mock return values to use bytes instead of strings
- Remove text=True from subprocess.run assertions
- Tests now match the new behavior that handles non-UTF-8 encodings
- All 133 tests passing with 72.67% coverage

Author: Arakiss

tests/test_git/test_commits.py

@@ -21,7 +21,7 @@ def test_create_commit_success(mock_run, git_operations):
         # git diff --cached --quiet
         MagicMock(returncode=1),  # Non-zero means there are staged changes
         # git commit
-        MagicMock(returncode=0, stdout="", stderr=""),
+        MagicMock(returncode=0, stdout=b"", stderr=b""),
     ]
 
     result = git_operations.create_commit(title="test: add new feature", message="Detailed commit message")
@@ -37,7 +37,6 @@ def test_create_commit_success(mock_run, git_operations):
             "Detailed commit message",
         ],
         capture_output=True,
-        text=True,
         check=True,
     )
 
@@ -66,7 +65,7 @@ def test_create_commit_with_warning(mock_logger, mock_run, git_operations):
         # git diff --cached --quiet
         MagicMock(returncode=1),  # Non-zero means there are staged changes
         # git commit
-        MagicMock(returncode=0, stderr="warning: CRLF will be replaced by LF", stdout=""),
+        MagicMock(returncode=0, stderr=b"warning: CRLF will be replaced by LF", stdout=b""),
     ]
 
     result = git_operations.create_commit(title="test", message="message")

tests/test_git/test_files.py

@@ -19,8 +19,8 @@ def test_get_diff_text_files(mock_run, git_operations, mock_git_file):
     """Test getting diff for text files."""
     mock_diff = "diff --git a/file1.py b/file1.py\n+new line"
     mock_run.return_value = MagicMock(
-        stdout=mock_diff,
-        stderr="",
+        stdout=mock_diff.encode('utf-8'),
+        stderr=b"",
         returncode=0,
     )
 
@@ -33,8 +33,8 @@ def test_get_diff_text_files(mock_run, git_operations, mock_git_file):
 def test_get_diff_binary_files(mock_run, git_operations, mock_git_file):
     """Test getting diff for binary files."""
     mock_run.return_value = MagicMock(
-        stdout="Binary files a/image.png and b/image.png differ",
-        stderr="",
+        stdout=b"Binary files a/image.png and b/image.png differ",
+        stderr=b"",
         returncode=0,
     )
 
@@ -50,7 +50,7 @@ def test_reset_staged_changes_success(mock_run, git_operations):
 
     git_operations.reset_staged_changes()
 
-    mock_run.assert_called_with(["git", "reset"], capture_output=True, text=True, check=True)
+    mock_run.assert_called_with(["git", "reset"], capture_output=True, check=True)
 
 
 @patch("subprocess.run")
@@ -70,8 +70,8 @@ def test_stage_files_with_warning(mock_logger, mock_run, git_operations):
     """Test handling of git warnings during staging."""
     mock_run.return_value = MagicMock(
         returncode=0,
-        stderr="warning: LF will be replaced by CRLF in file1.py",
-        stdout="",
+        stderr=b"warning: LF will be replaced by CRLF in file1.py",
+        stdout=b"",
     )
 
     git_operations.stage_files(["file1.py"])
@@ -90,8 +90,8 @@ def test_stage_files_with_info(mock_logger, mock_run, git_operations):
     """Test handling of git info messages during staging."""
     mock_run.return_value = MagicMock(
         returncode=0,
-        stderr="Updating index",
-        stdout="",
+        stderr=b"Updating index",
+        stdout=b"",
     )
 
     git_operations.stage_files(["file1.py"])

tests/test_git/test_operations.py

@@ -24,8 +24,8 @@ def test_should_ignore_file(git_operations):
 def test_get_staged_files_success(mock_run, git_operations, mock_git_file):
     """Test successful retrieval of staged files."""
     mock_run.return_value = MagicMock(
-        stdout=" M file1.py\nM  file2.py\n",
-        stderr="",
+        stdout=b" M file1.py\nM  file2.py\n",
+        stderr=b"",
         returncode=0,
     )
 
@@ -41,7 +41,7 @@ def test_get_staged_files_success(mock_run, git_operations, mock_git_file):
 @patch("subprocess.run")
 def test_get_staged_files_empty(mock_run, git_operations):
     """Test when no files are staged."""
-    mock_run.return_value = MagicMock(stdout="", stderr="", returncode=0)
+    mock_run.return_value = MagicMock(stdout=b"", stderr=b"", returncode=0)
 
     files = git_operations.get_staged_files()
 
@@ -63,8 +63,8 @@ def test_get_staged_files_error(mock_run, git_operations):
 def test_get_staged_files_with_renames(mock_run, git_operations):
     """Test handling of renamed files."""
     mock_run.return_value = MagicMock(
-        stdout='R  "old file.py" -> "new file.py"\n',
-        stderr="",
+        stdout=b'R  "old file.py" -> "new file.py"\n',
+        stderr=b"",
         returncode=0,
     )
 
@@ -80,8 +80,8 @@ def test_get_staged_files_with_renames(mock_run, git_operations):
 def test_get_staged_files_ignores_untracked(mock_run, git_operations):
     """Test that untracked files are ignored."""
     mock_run.return_value = MagicMock(
-        stdout="?? new.py\n M tracked.py\n",
-        stderr="",
+        stdout=b"?? new.py\n M tracked.py\n",
+        stderr=b"",
         returncode=0,
     )
 
@@ -94,9 +94,9 @@ def test_get_staged_files_ignores_untracked(mock_run, git_operations):
 
 def test_get_staged_files_with_spaces(git_operations):
     """Test getting staged files with spaces in paths."""
-    mock_output = "M  path with spaces/file.py\nA  another path/with spaces.py\n"
+    mock_output = b"M  path with spaces/file.py\nA  another path/with spaces.py\n"
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 2
@@ -106,9 +106,9 @@ def test_get_staged_files_with_spaces(git_operations):
 
 def test_get_staged_files_with_special_chars(git_operations):
     """Test getting staged files with special characters."""
-    mock_output = "M  path/with-dashes.py\nA  path/with_underscores.py\nM  path/with.dots.py\n"
+    mock_output = b"M  path/with-dashes.py\nA  path/with_underscores.py\nM  path/with.dots.py\n"
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 3
@@ -119,9 +119,9 @@ def test_get_staged_files_with_special_chars(git_operations):
 
 def test_get_staged_files_with_unicode(git_operations):
     """Test getting staged files with unicode characters."""
-    mock_output = "M  path/with/émoji/🚀.py\nA  path/with/áccents/file.py\n"
+    mock_output = "M  path/with/émoji/🚀.py\nA  path/with/áccents/file.py\n".encode('utf-8')
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 2
@@ -131,8 +131,8 @@ def test_get_staged_files_with_unicode(git_operations):
 
 def test_get_staged_files_with_warnings(git_operations):
     """Test getting staged files with git warnings."""
-    mock_output = "M  file.py\n"
-    mock_warning = "warning: CRLF will be replaced by LF in file.py"
+    mock_output = b"M  file.py\n"
+    mock_warning = b"warning: CRLF will be replaced by LF in file.py"
     with patch("subprocess.run") as mock_run:
         mock_run.return_value = MagicMock(stdout=mock_output, stderr=mock_warning, returncode=0)
         files = git_operations.get_staged_files()
@@ -143,19 +143,19 @@ def test_get_staged_files_with_warnings(git_operations):
 
 def test_get_staged_files_with_binary_detection(git_operations):
     """Test getting staged files with binary file detection."""
-    mock_output = "M  text.py\nM  image.png\n"
+    mock_output = b"M  text.py\nM  image.png\n"
 
     def mock_run_side_effect(*args, **kwargs):
         if args[0][0] == "git" and args[0][1] == "status":
-            return MagicMock(stdout=mock_output, stderr="", returncode=0)
+            return MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         elif args[0][0] == "git" and args[0][1] == "diff":
             # Return binary file indicator for image.png
             if "image.png" in args[0]:
-                return MagicMock(stdout="-\t-\timage.png\n", stderr="", returncode=0)
-            return MagicMock(stdout="1\t1\ttext.py\n", stderr="", returncode=0)
+                return MagicMock(stdout=b"-\t-\timage.png\n", stderr=b"", returncode=0)
+            return MagicMock(stdout=b"1\t1\ttext.py\n", stderr=b"", returncode=0)
         elif args[0][0] == "git" and args[0][1] == "hash-object":
-            return MagicMock(stdout="abc123\n", stderr="", returncode=0)
-        return MagicMock(stdout="", stderr="", returncode=0)
+            return MagicMock(stdout=b"abc123\n", stderr=b"", returncode=0)
+        return MagicMock(stdout=b"", stderr=b"", returncode=0)
 
     with patch("subprocess.run", side_effect=mock_run_side_effect):
         with patch("os.path.exists", return_value=True):
@@ -172,12 +172,12 @@ def mock_run_side_effect(*args, **kwargs):
 def test_get_staged_files_with_complex_renames(git_operations):
     """Test getting staged files with complex rename scenarios."""
     mock_output = (
-        "R  old_name.py -> new_name.py\n"
-        "R  old/path/file.py -> new/path/file.py\n"
-        "R100  renamed_completely.py -> totally_different.py\n"
+        b"R  old_name.py -> new_name.py\n"
+        b"R  old/path/file.py -> new/path/file.py\n"
+        b"R100  renamed_completely.py -> totally_different.py\n"
     )
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 3
@@ -189,9 +189,9 @@ def test_get_staged_files_with_complex_renames(git_operations):
 
 def test_get_staged_files_with_submodules(git_operations):
     """Test getting staged files with submodule changes."""
-    mock_output = "M  regular_file.py\nM  submodule\n"  # Submodule change
+    mock_output = b"M  regular_file.py\nM  submodule\n"  # Submodule change
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 2
@@ -201,9 +201,9 @@ def test_get_staged_files_with_submodules(git_operations):
 
 def test_get_staged_files_with_permission_changes(git_operations):
     """Test getting staged files with permission changes."""
-    mock_output = "M  file_with_chmod.sh\n"
+    mock_output = b"M  file_with_chmod.sh\n"
     with patch("subprocess.run") as mock_run:
-        mock_run.return_value = MagicMock(stdout=mock_output, stderr="", returncode=0)
+        mock_run.return_value = MagicMock(stdout=mock_output, stderr=b"", returncode=0)
         files = git_operations.get_staged_files()
 
     assert len(files) == 1