include full url in cache key #7
Merged
+249
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comhar
force-pushed
the
feat/5-use-full-url-in-cache-key
branch
from
84caf34 to
f449b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5
This pr updates
_keyso that the full url is included in the cache key. Up until now only the host was included.This change was needed because LiteLLM includes the model name in a query param when calling Gemini. Running the same prompt on two different Gemini models would generate the same cache key making it difficult to compare Gemini models. This PR resolves that issue.
Note: This is a breaking change. If your project relies on cachy, probably best to delete your
cachy.jsonl, run your notebooks and commit the newcachy.jsonl.