Skip to content

Conversation

@decherd
Copy link

@decherd decherd commented Nov 10, 2025

Summary

This PR changes the cache key to use the full URL without the key parameter

Issue

Closes #5

@comhar comhar self-requested a review November 12, 2025 15:58
@comhar
Copy link
Contributor

comhar commented Nov 13, 2025

Summary

This PR changes the cache key to use the full URL without the key parameter

Issue

Closes #5

Thanks @decherd. Tested the changes locally and they seem to be working fine 👍

I created a sister pr here which implements your change. That pr also adds a test, updates some prose, clears out the cache and re-populates it. If you like I can assign you to that pr so you get the credit for the change? If that sounds ok, I'll go ahead and merge it.

@comhar
Copy link
Contributor

comhar commented Dec 2, 2025

@decherd I merged the sister PR so I'm closing this pr now. Unfortunately, Github wouldn't let me assign the sister PR to you but I'll assign you in the release notes.

@comhar comhar closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use full url without key param in cache key

2 participants