🛠️ Fix #218

Block displays should not respect the `facing` state.

Author: SnaveSutit

src/outliner/vanillaBlockDisplay.ts

@@ -240,8 +240,6 @@ export const PREVIEW_CONTROLLER = new NodePreviewController(VanillaBlockDisplay,
 				el.preview_controller.updateTransform(el)
 				el.mesh.visible = el.visibility
 				TickUpdates.selection = true
-
-				el.ready = true
 			})
 			.catch(err => {
 				console.error(err)
@@ -254,6 +252,7 @@ export const PREVIEW_CONTROLLER = new NodePreviewController(VanillaBlockDisplay,
 					if (el.error.get()) el.mesh.outline.material = ERROR_OUTLINE_MATERIAL
 					else el.mesh.outline.material = Canvas.outlineMaterial
 				}
+				el.ready = true
 			})
 	},
 	updateTransform(el: VanillaBlockDisplay) {

src/outliner/vanillaItemDisplay.ts

@@ -14,6 +14,9 @@ import { ResizableOutlinerElement } from './resizableOutlinerElement'
 import { TextDisplay } from './textDisplay'
 import { VanillaBlockDisplay } from './vanillaBlockDisplay'
 
+const ERROR_OUTLINE_MATERIAL = Canvas.outlineMaterial.clone()
+ERROR_OUTLINE_MATERIAL.color.set('#ff0000')
+
 interface VanillaItemDisplayOptions {
 	name?: string
 	item?: string
@@ -237,14 +240,19 @@ export const PREVIEW_CONTROLLER = new NodePreviewController(VanillaItemDisplay,
 				el.preview_controller.updateTransform(el)
 				el.mesh.visible = el.visibility
 				TickUpdates.selection = true
-
-				el.ready = true
 			})
 			.catch(err => {
 				if (typeof err.message === 'string') {
 					el.error.set(err.message as string)
 				}
 			})
+			.finally(() => {
+				if (el.mesh?.outline instanceof THREE.LineSegments) {
+					if (el.error.get()) el.mesh.outline.material = ERROR_OUTLINE_MATERIAL
+					else el.mesh.outline.material = Canvas.outlineMaterial
+				}
+				el.ready = true
+			})
 	},
 	updateTransform(el: VanillaItemDisplay) {
 		ResizableOutlinerElement.prototype.preview_controller.updateTransform(el)

src/systems/minecraft/blockModelManager.ts

@@ -42,11 +42,14 @@ const BLACKLISTED_BLOCKS = new Map([
 	['piglin_wall_head', translate('block_model_manager.mob_head_warning')],
 ])
 
+const BLACKLISTED_BLOCKSTATES = new Map([
+	['facing', translate('block_model_manager.facing_warning')],
+])
+
 export async function getBlockModel(block: string): Promise<BlockModelMesh | undefined> {
 	await assetsLoaded()
 	let result = BLOCK_MODEL_CACHE.get(block)
 	if (!result) {
-		// console.warn(`Found no cached item model mesh for '${block}'`)
 		const parsed = await parseBlock(block)
 		if (!parsed) return undefined
 		if (BLACKLISTED_BLOCKS.has(block)) {
@@ -383,6 +386,9 @@ export async function parseBlockState(block: IParsedBlock): Promise<BlockModelMe
 		} else if (!block.blockStateRegistryEntry.stateValues[k].includes(v)) {
 			throw new Error(`Invalid block state value '${v.toString()}' for '${k}'`)
 		}
+		if (BLACKLISTED_BLOCKSTATES.has(k)) {
+			block.states[k] = block.blockStateRegistryEntry.defaultStates[k]
+		}
 	}
 
 	if (blockstate.variants) {

test_blueprints/armor_stand.ajblueprint

@@ -3006,7 +3006,7 @@
 			"override": false,
 			"length": 0.8,
 			"snapping": 20,
-			"selected": true,
+			"selected": false,
 			"saved": false,
 			"path": "",
 			"anim_time_update": "",