🚧 Prevent editing default variant config

Author: SnaveSutit

src/components/variantsPanel.svelte

@@ -137,11 +137,19 @@
 						{item.value.displayName}
 					</div>
 					<div class="spacer" />
-					<i
-						class="material-icons icon in_list_button"
-						title={translate('panel.variants.tool.edit_variant')}
-						on:click={() => openVariantConfigDialog(item.value)}>edit</i
-					>
+					{#if item.value.isDefault}
+						<i
+							class="material-icons icon in_list_button in_list_button_disabled"
+							title={translate('panel.variants.tool.edit_variant')}
+							on:click={() => openVariantConfigDialog(item.value)}>edit</i
+						>
+					{:else}
+						<i
+							class="material-icons icon in_list_button"
+							title={translate('panel.variants.tool.cannot_edit_default_variant')}
+							on:click={() => openVariantConfigDialog(item.value)}>edit</i
+						>
+					{/if}
 					{#if Variant.selected === item.value}
 						<i
 							class="material-icons icon in_list_button"

src/interface/variantsPanel.ts

@@ -38,7 +38,7 @@ export const DELETE_VARIANT_ACTION = createAction(`${PACKAGE.name}:deleteVariant
 export const OPEN_VARIANT_CONFIG_ACTION = createAction(`${PACKAGE.name}:openVariantConfig`, {
 	name: translate('action.variants.open_config'),
 	icon: 'settings',
-	condition: () => !!Variant.selected,
+	condition: () => !!Variant.selected && !Variant.selected.isDefault,
 	click() {
 		if (!Variant.selected) return
 		openVariantConfigDialog(Variant.selected)
@@ -47,9 +47,10 @@ export const OPEN_VARIANT_CONFIG_ACTION = createAction(`${PACKAGE.name}:openVari
 
 export const VARIANT_PANEL_CONTEXT_MENU = createMenu(
 	[
+		OPEN_VARIANT_CONFIG_ACTION.id,
+		new MenuSeparator(),
 		CREATE_VARIANT_ACTION.id,
 		DUPLICATE_VARIANT_ACTION.id,
-		OPEN_VARIANT_CONFIG_ACTION.id,
 		new MenuSeparator(),
 		DELETE_VARIANT_ACTION.id,
 	],

src/lang/en.yml

@@ -440,6 +440,7 @@ animated_java.panel.variants.tool.delete_selected_variant: Delete Selected Varia
 animated_java.panel.variants.tool.variant_visible: Variant Selected
 animated_java.panel.variants.tool.variant_not_visible: Variant Not Selected
 animated_java.panel.variants.tool.cannot_delete_default_variant: Cannot delete the default variant!
+animated_java.panel.variants.tool.cannot_edit_default_variant: Cannot edit the default variant!
 
 animated_java.action.variants.create: Create Variant
 animated_java.action.variants.duplicate: Duplicate Variant

src/variants.ts

@@ -106,12 +106,16 @@ export class Variant {
 	constructor(displayName: string, isDefault = false) {
 		this.displayName = Variant.makeDisplayNameUnique(this, displayName)
 		this.name = Variant.makeNameUnique(this, this.displayName)
-		this.uuid = guid()
 		this.isDefault = isDefault
+		this.uuid = guid()
 		this.textureMap = new TextureMap()
 		this.id = Variant.all.length
+		if (this.isDefault) {
+			this.displayName = 'Default'
+			this.name = 'default'
+		}
 		Variant.all.push(this)
-		this.select()
+		// this.select()
 		events.CREATE_VARIANT.dispatch(this)
 	}
 
@@ -173,6 +177,9 @@ export class Variant {
 
 	public static fromJSON(json: IBlueprintVariantJSON, isDefault = false): Variant {
 		const variant = new Variant(json.display_name, isDefault)
+		if (json.is_default) {
+			return variant
+		}
 		variant.uuid = json.uuid
 		for (const [key, value] of Object.entries(json.texture_map)) {
 			variant.textureMap.add(key, value)