fix(nvme): zero the queue

Signed-off-by: Anhad Singh <andypythonappdeveloper@gmail.com>

Author: Andy-Python-Programmer

src/aero_kernel/src/drivers/block/nvme/queue.rs

@@ -1,4 +1,5 @@
 use core::cell::UnsafeCell;
+use core::ptr;
 use core::sync::atomic::{AtomicU16, Ordering};
 
 use crate::mem::paging::PhysAddr;
@@ -56,7 +57,7 @@ impl<'bell, T: QueueType> Queue<'bell, T> {
 
         Ok(Self {
             doorbell,
-            queue: unsafe { Dma::new_uninit_slice(size).assume_init() },
+            queue: unsafe { Dma::new_zeroed_slice(size).assume_init() },
             index: 0,
             phase: true,
         })
@@ -139,7 +140,7 @@ impl<'a> QueuePair<'a> {
         unsafe {
             // SAFETY: The offset of the `command_id` field is the same, regardless of the command
             // type.
-            command.common.command_id = self.cid;
+            *ptr::addr_of_mut!(command).cast::<u16>().add(1) = self.cid;
         }
 
         self.cid += 1;

src/aero_kernel/src/utils/dma.rs

@@ -32,7 +32,7 @@ unsafe impl Allocator for DmaAllocator {
     fn allocate(&self, layout: Layout) -> Result<NonNull<[u8]>, AllocError> {
         let size_bytes = layout.size();
 
-        let phys = FRAME_ALLOCATOR.alloc_zeroed(size_bytes).ok_or(AllocError)?;
+        let phys = FRAME_ALLOCATOR.alloc(size_bytes).ok_or(AllocError)?;
         let virt = phys.as_hhdm_virt();
 
         // SAFETY: The frame is aligned and non-null.
@@ -78,6 +78,10 @@ impl<T> Dma<T> {
     pub fn new_uninit_slice(len: usize) -> Dma<[MaybeUninit<T>]> {
         Dma(DmaBuffer::new_uninit_slice_in(len, DmaAllocator))
     }
+
+    pub fn new_zeroed_slice(len: usize) -> Dma<[MaybeUninit<T>]> {
+        Dma(DmaBuffer::new_zeroed_slice_in(len, DmaAllocator))
+    }
 }
 
 impl<T> Dma<[MaybeUninit<T>]> {