fix: ignore completion requests when editor is not attached to window (fixes #1739)

itsaky · itsaky · commit c894d3d9d69e · 2024-03-02T20:50:01.000+05:30
diff --git a/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt b/editor/src/main/java/com/itsaky/androidide/editor/ui/EditorCompletionWindow.kt
@@ -27,7 +27,6 @@ import com.itsaky.androidide.utils.KeyboardUtils
 import io.github.rosemoe.sora.lang.completion.CompletionItem
 import io.github.rosemoe.sora.widget.component.CompletionLayout
 import io.github.rosemoe.sora.widget.component.EditorAutoCompletion
-import io.github.rosemoe.sora.widget.getComponent
 import java.lang.ref.WeakReference
 import kotlin.math.min
 
@@ -103,7 +102,7 @@ class EditorCompletionWindow(val editor: IDEEditor) : EditorAutoCompletion(edito
   }
 
   override fun requireCompletion() {
-    if (cancelShowUp || !isEnabled) {
+    if (cancelShowUp || !isEnabled || !editor.isAttachedToWindow) {
       return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ import com.itsaky.androidide.utils.KeyboardUtils`
`27`	`27`	`import io.github.rosemoe.sora.lang.completion.CompletionItem`
`28`	`28`	`import io.github.rosemoe.sora.widget.component.CompletionLayout`
`29`	`29`	`import io.github.rosemoe.sora.widget.component.EditorAutoCompletion`
`30`		`-import io.github.rosemoe.sora.widget.getComponent`
`31`	`30`	`import java.lang.ref.WeakReference`
`32`	`31`	`import kotlin.math.min`
`33`	`32`
`@@ -103,7 +102,7 @@ class EditorCompletionWindow(val editor: IDEEditor) : EditorAutoCompletion(edito`
`103`	`102`	`}`
`104`	`103`
`105`	`104`	`override fun requireCompletion() {`
`106`		`- if (cancelShowUp \|\| !isEnabled) {`
	`105`	`+ if (cancelShowUp \|\| !isEnabled \|\| !editor.isAttachedToWindow) {`
`107`	`106`	`return`
`108`	`107`	`}`
`109`	`108`