commented code, tslint & readme updated

Author: AndrewJBateman

.firebaserc

@@ -1,5 +1,6 @@
 {
   "projects": {
-    "default": "ionic-angular-pr-1565107344855"
+    "default": "ionic-angular-pr-1565107344855",
+    "testing": "ionic-angular-pr-1565107344855"
   }
 }

README.md

@@ -29,9 +29,19 @@ Code taken from course.
 
 **of** used with a single value for an 'emit once and complete' stream.
 
-**take** tba
+**take** emits only the first n values from an observable (e.g. take(1) emits only the first 2 values )
 
-**tap** tba
+**tap** used to perform side effects. Every data value is received from the source, an action is taken on a part of the data then the data passeed on unchanged.
+
+**map** passes each source value through a transformation function then outputs the results, e.g map(x => 10*x)
+
+## Observables
+
+An [observable](https://rxjs-dev.firebaseapp.com/guide/observable) is created using 'new Observable'. It is subscribed to using an Observer and executed to deliver next / error / complete notices to the Observer, before the execution is disposed of. Sbscribers should be wrapped in try/catch blocks.
+
+## Array Operators
+
+* [Array.push()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/push) adds one or more elements to the end of an array and returns the new aray length.
 
 ## Screenshots
 

src/app/auth/auth.guard.ts

@@ -26,8 +26,8 @@ export class AuthGuard implements CanLoad {
 			}),
 			tap(isAuthenticated => {
 				if (!isAuthenticated) {
-				this.router.navigateByUrl('/auth');
-			}
+					this.router.navigateByUrl('/auth');
+				}
 			})
 		);
 	}

src/app/auth/auth.page.ts

@@ -40,7 +40,6 @@ export class AuthPage implements OnInit {
 				}
 				authObs.subscribe(
 					resData => {
-						console.log(resData);
 						this.isLoading = false;
 						loadingEl.dismiss();
 						this.router.navigateByUrl('/places/tabs/discover');

src/app/auth/auth.service.ts

@@ -21,7 +21,7 @@ export interface AuthResponseData {
 	providedIn: 'root'
 })
 export class AuthService implements OnDestroy {
-	// tslint:disable-next-line: variable-name
+
 	private _user = new BehaviorSubject<User>(null);
 	private activeLogoutTimer: any;
 
@@ -181,7 +181,6 @@ export class AuthService implements OnDestroy {
 			tokenExpirationDate,
 			email
 		});
-		console.log('auth data: ', data);
 		Plugins.Storage.set({ key: 'authData', value: data });
 	}
 }

src/app/bookings/booking.service.ts

@@ -20,7 +20,6 @@ interface BookingData {
 
 @Injectable({ providedIn: 'root' })
 export class BookingService {
-	// tslint:disable-next-line: variable-name
 	private _bookings = new BehaviorSubject<Booking[]>([]);
 
 	get bookings() {

src/app/bookings/bookings.page.ts

@@ -27,6 +27,7 @@ export class BookingsPage implements OnInit, OnDestroy {
 		});
 	}
 
+	// lifecycle event fired when entering a page
 	ionViewWillEnter() {
 		this.isLoading = true;
 		this.bookingService.fetchBookings().subscribe(() => {

src/app/places/places-routing.module.ts

@@ -1,5 +1,6 @@
 import { RouterModule, Routes } from '@angular/router';
 import { NgModule } from '@angular/core';
+
 import { PlacesPage } from './places.page';
 
 const routes: Routes = [

src/app/places/places.service.ts

@@ -55,7 +55,6 @@ interface PlaceData {
 	providedIn: 'root'
 })
 export class PlacesService {
-	// tslint:disable-next-line: variable-name
 	private _places = new BehaviorSubject<Place[]>([]);
 
 	get places() {
@@ -101,7 +100,7 @@ export class PlacesService {
 
 	getPlace(id: string) {
 		return this.authService.token.pipe(
-			take(1),
+			take(1), // only need one token
 			switchMap(token => {
 				return this.http.get<PlaceData>(
 					`https://ionic-angular-pr-1565107344855.firebaseio.com/offered-places/${id}.json?auth=${token}`
@@ -131,7 +130,8 @@ export class PlacesService {
 			take(1),
 			switchMap(token => {
 				return this.http.post<{ imageUrl: string, imagePath: string }>(
-					'https://us-central1-ionic-angular-pr-1565107344855.cloudfunctions.net/storeImage',
+					// 'https://eur3-ionic-angular-pr-1565107344855.cloudfunctions.net/storeImage',
+					'gs://ionic-angular-pr-1565107344855.appspot.com/',
 					uploadData, {headers: { Authorization: 'Bearer ' + token } }
 				);
 			})

tslint.json

@@ -4,6 +4,10 @@
     "codelyzer"
   ],
   "rules": {
+    "variable-name": [true,
+      "check-format",
+      "allow-leading-underscore"
+    ],
     "indent": [
       true,
       "tabs",