Skip to content

Commit 4e315c1

Browse files
minor improvements to discover page, readme updates
1 parent d2401b1 commit 4e315c1

File tree

8 files changed

+14
-16
lines changed

8 files changed

+14
-16
lines changed

README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Ionic Angular Project
22

3-
App to create an Airbnb-style app, following Udemy Tutorial: [Ionic 4 - Build iOS, Android & Web Apps with Ionic & Angular](https://www.udemy.com/ionic-2-the-practical-guide-to-building-ios-android-apps/), using the [Ionic 5 framework](https://ionicframework.com/docs).
4-
Code taken from course.
3+
App to create Airbnb-style property listings with pages to make bookings and update property details. Code taken from Udemy Tutorial: [Ionic 4 - Build iOS, Android & Web Apps with Ionic & Angular](https://www.udemy.com/ionic-2-the-practical-guide-to-building-ios-android-apps/), using the [Ionic 5 framework](https://ionicframework.com/docs).
54

65
## Table of contents
76

@@ -16,10 +15,10 @@ Code taken from course.
1615

1716
## General info
1817

19-
* App to view and book places to stay. All places listed on the 'discover.page' and clicking on an item navigates to a place detail page using the place id in the browser.
20-
* Places are displayed under 2 list option: 'ALL PLACES' and 'BOOKABLE PLACES'. The first place is displayed using an ion-card, the remaining places are displayed using a list with a thumbnail image. There is code to prevent the user from being able to book their own places, using a userId matching function.
18+
* App to view and book places to stay. All places listed on the 'discover.page' and clicking on an item navigate to a place detail page using the place id in the browser.
19+
* Places are displayed under 2 list option: 'ALL PLACES' and 'BOOKABLE PLACES'. The first place is displayed using an ion-card, the remaining places are displayed using a list with a thumbnail image. There is code to prevent the user from being able to book their own places, using a userId matching function to show/hide the booking button.
2120
* Places can be booked, listed and cancelled.
22-
* New places can be added. The location of the new place is chosen using google maps and is displayed in the template using data-binding. A photo can be taken to add to the new Place description. If there is no camera then there is a file upload button to save a jpeg image.
21+
* New places can be added as 'Offers'. The location of the new place is chosen using the Google Maps API and is displayed in the template using data-binding. A photo can be taken to add to the new Place description. If there is no camera then there is a file upload button to save a jpeg image.The Firestore Function
2322
* Burger side panel added with links to the discover places listings, your bookings and a logout button.
2423
* Bottom menu with 2 links to 'Discover' (default page upon loading) and 'Offers' that lists all the places available.
2524

@@ -60,7 +59,9 @@ a [BehaviourSubject](http://reactivex.io/rxjs/manual/overview.html#behaviorsubje
6059
## Screenshots
6160

6261
![page](./img/discover-places-page.png)
63-
![page](./img/offers-page.png)
62+
![page](./img/discover-place-detail.png)
63+
![page](./img/new-offer.png)
64+
![page](./img/my-offers-page.png)
6465
![page](./img/firebase-database.png)
6566

6667
## Technologies
@@ -150,7 +151,7 @@ private getGoogleMaps(): Promise<any> {
150151
## Status & To-do list
151152

152153
* Status: working. Bookings can be made and new places added to offers page. If a different user is logged in they cannot book their own places (the booking button does not show) - which is correct. Camera images now show.
153-
* To-do: Bookable place list is the same as the 'All Places' list - bookable places should not include the logged in users' places. 'My Offers' includes everyones places. Booking a place works but fix error with template ion-datetime and datesValid() function - "TypeError: Cannot read property 'value' of undefined".
154+
* To-do: Bookable place list is the same as the 'All Places' list - bookable places should not include the logged in users' places. 'My Offers' includes everyones places.
154155

155156
## Inspiration
156157

img/discover-place-detail.png

261 KB
Loading

img/discover-places-page.png

7.85 KB
Loading

img/my-offers-page.png

220 KB
Loading

img/new-offer.png

170 KB
Loading

img/offers-page.png

-118 KB
Binary file not shown.

src/app/bookings/bookings.page.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { Subscription } from 'rxjs';
55
import { BookingService } from './booking.service';
66
import { Booking } from './booking.model';
77

8-
98
@Component({
109
selector: 'app-bookings',
1110
templateUrl: './bookings.page.html',

src/app/places/discover/discover.page.html

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,13 @@
22
<ion-toolbar>
33
<ion-buttons slot="start">
44
<ion-menu-button></ion-menu-button>
5-
<!-- <ion-button (click)="onOpenMenu"> -->
6-
<!-- Open
7-
</ion-button> -->
85
</ion-buttons>
96
<ion-title>Discover Places</ion-title>
107
</ion-toolbar>
118
</ion-header>
129

13-
<ion-content padding>
14-
<ion-segment (ionChange)="onFilterUpdate($event)">
10+
<ion-content>
11+
<ion-segment (ionChange)="onFilterUpdate($event)" padding>
1512
<ion-segment-button value="all" checked>All Places</ion-segment-button>
1613
<ion-segment-button value="bookable">Bookable Places</ion-segment-button>
1714
</ion-segment>
@@ -34,7 +31,7 @@
3431

3532
<ion-grid *ngIf="!isLoading && relevantPlaces.length > 0">
3633
<ion-row>
37-
<ion-col size="12" size-sm="8" offset-sm="2" text-center>
34+
<ion-col size="12" size-sm="8" size-ms="8" size-xl="6" offset-sm="2" text-center>
3835
<ion-card>
3936
<ion-card-header>
4037
<ion-card-title>{{ relevantPlaces[0].title }}</ion-card-title>
@@ -47,15 +44,16 @@
4744
<div>
4845
<ion-button
4946
fill="clear"
50-
color="primary"
47+
color="tertiary"
48+
routerDirection="forward"
5149
[routerLink]="[
5250
'/',
5351
'places',
5452
'tabs',
5553
'discover',
5654
relevantPlaces[0].id
5755
]">
58-
More
56+
View
5957
</ion-button>
6058
</div>
6159
</ion-card>

0 commit comments

Comments
 (0)