From d434c2151fcc71cd7213a0ce485ace4f5d6f4b58 Mon Sep 17 00:00:00 2001 From: Luca Ban Date: Mon, 26 May 2025 10:23:03 +1200 Subject: [PATCH 1/2] fix: add the correct type to events --- src/useDraggable.ts | 46 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/src/useDraggable.ts b/src/useDraggable.ts index 5bb9bf5..e06d364 100644 --- a/src/useDraggable.ts +++ b/src/useDraggable.ts @@ -94,7 +94,51 @@ export interface UseDraggableReturn extends Pick { export interface UseDraggableOptions extends Options { clone?: (element: T) => T immediate?: boolean - customUpdate?: (event: SortableEvent) => void + customUpdate?: (event: DraggableEvent) => void + /** + * Element dragging started + */ + onStart?: ((event: DraggableEvent) => void) | undefined; + /** + * Element dragging ended + */ + onEnd?: ((event: DraggableEvent) => void) | undefined; + /** + * Element is dropped into the list from another list + */ + onAdd?: ((event: DraggableEvent) => void) | undefined; + /** + * Created a clone of an element + */ + onClone?: ((event: DraggableEvent) => void) | undefined; + /** + * Element is chosen + */ + onChoose?: ((event: DraggableEvent) => void) | undefined; + /** + * Element is unchosen + */ + onUnchoose?: ((event: DraggableEvent) => void) | undefined; + /** + * Changed sorting within list + */ + onUpdate?: ((event: DraggableEvent) => void) | undefined; + /** + * Called by any change to the list (add / update / remove) + */ + onSort?: ((event: DraggableEvent) => void) | undefined; + /** + * Element is removed from the list into another list + */ + onRemove?: ((event: DraggableEvent) => void) | undefined; + /** + * Attempt to drag a filtered element + */ + onFilter?: ((event: DraggableEvent) => void) | undefined; + /** + * Called when dragging element changes position + */ + onChange?: ((evt: DraggableEvent) => void) | undefined; } /** From 846427e5efc757e6a2f5ba3314d9e35071b6a452 Mon Sep 17 00:00:00 2001 From: Luca Ban Date: Mon, 26 May 2025 10:23:37 +1200 Subject: [PATCH 2/2] lint --- src/useDraggable.ts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/useDraggable.ts b/src/useDraggable.ts index e06d364..c0dcbdd 100644 --- a/src/useDraggable.ts +++ b/src/useDraggable.ts @@ -98,47 +98,47 @@ export interface UseDraggableOptions extends Options { /** * Element dragging started */ - onStart?: ((event: DraggableEvent) => void) | undefined; + onStart?: ((event: DraggableEvent) => void) | undefined /** * Element dragging ended */ - onEnd?: ((event: DraggableEvent) => void) | undefined; + onEnd?: ((event: DraggableEvent) => void) | undefined /** * Element is dropped into the list from another list */ - onAdd?: ((event: DraggableEvent) => void) | undefined; + onAdd?: ((event: DraggableEvent) => void) | undefined /** * Created a clone of an element */ - onClone?: ((event: DraggableEvent) => void) | undefined; + onClone?: ((event: DraggableEvent) => void) | undefined /** * Element is chosen */ - onChoose?: ((event: DraggableEvent) => void) | undefined; + onChoose?: ((event: DraggableEvent) => void) | undefined /** * Element is unchosen */ - onUnchoose?: ((event: DraggableEvent) => void) | undefined; + onUnchoose?: ((event: DraggableEvent) => void) | undefined /** * Changed sorting within list */ - onUpdate?: ((event: DraggableEvent) => void) | undefined; + onUpdate?: ((event: DraggableEvent) => void) | undefined /** * Called by any change to the list (add / update / remove) */ - onSort?: ((event: DraggableEvent) => void) | undefined; + onSort?: ((event: DraggableEvent) => void) | undefined /** * Element is removed from the list into another list */ - onRemove?: ((event: DraggableEvent) => void) | undefined; + onRemove?: ((event: DraggableEvent) => void) | undefined /** * Attempt to drag a filtered element */ - onFilter?: ((event: DraggableEvent) => void) | undefined; + onFilter?: ((event: DraggableEvent) => void) | undefined /** * Called when dragging element changes position */ - onChange?: ((evt: DraggableEvent) => void) | undefined; + onChange?: ((evt: DraggableEvent) => void) | undefined } /**