This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Allow CameraViewController to be used in a navigation stack without losing completion #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osing its completion - Wes & Megan
Tulleb
force-pushed
the
master
branch
2 times, most recently
from
3d556d8 to
2cd2215
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CameraViewController is on a Navigation Stack, a picture is taken, and a new ViewController is pushed on the stack, when you hit back to return to the CameraViewController, the completion no longer exists and can no longer be called, making it impossible to leave the CameraViewController. We removed clearing out the completion blocks. This should be ok and not leave retain cycles because the presenting CameraViewController has the only reference to the completion.