-
Notifications
You must be signed in to change notification settings - Fork 52
Adding AWS SigV4 authentication #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here. |
|
I see your point, but perhaps supporting aws out of the box would be worth the trade off. I believe that using opensearch as an aws service is a very common use case. |
@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well. |
@fabiojmendes. We do want to see you solution.I personally think this is a valuable feature. Since we need to add support SSL configuration it will take sometime. @reta I think we need to add a separate project which will build together with the connector as separate jar/jars with additional auth libs. Wdyt? |
|
Sounds good @willyborankin, do you need any changes from my side at this point? |
|
what is the status of this? it would be great to have support for IAM role authentication in the connector out of the box... |
|
Is there still interest from the maintainers to merge this PR? |
|
Trying to make it work with aws opensearch serverless, the feature would be extremely helpful. Edit - I am using strimzi kafka connect, so i will need IRSA to work. |
|
Another update - For now I am able to make it work using |
|
@reta any chance to get this merged and released? |
This pull request implements the AWS SigV4 as described in #197