Handle 400, 422, 500 responses

Author: gcatanese

lib/adyen/client.rb

@@ -215,13 +215,19 @@ def call_adyen_api(service, action, request_data, headers, version, _with_applic
       end
       # check for API errors
       case response.status
+      when 400
+        raise Adyen::FormatError.new('Invalid format or fields', request_data, response.body)
       when 401
         raise Adyen::AuthenticationError.new(
           'Invalid API authentication; https://docs.adyen.com/user-management/how-to-get-the-api-key', request_data
         )
       when 403
         raise Adyen::PermissionError.new('Missing user permissions; https://docs.adyen.com/user-management/user-roles',
                                          request_data, response.body)
+      when 422
+        raise Adyen::ValidationError.new('Validation error', request_data, response.body)
+      when 500..599
+        raise Adyen::ServerError.new('Internal server error', request_data, response.body)
       end
 
       # delete has no response.body (unless it throws an error)

spec/client_spec.rb

@@ -302,4 +302,55 @@
     expect(client.service_url_base('Disputes'))
       .to eq('https://ca-test.adyen.com/ca/services/DisputesService')
   end  
+
+  it 'raises FormatError on 400 response and checks content' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    mock_faraday_connection = double(Faraday::Connection)
+    error_body = {
+      status: 400,
+      errorCode: "702",
+      message: "Structure of CreateCheckoutSessionRequest contains the following unknown fields: [paymentMethod]",
+      errorType: "validation"
+    }
+    mock_response = Faraday::Response.new(status: 400, body: error_body)
+
+    allow(Faraday).to receive(:new).and_return(mock_faraday_connection)
+    allow(mock_faraday_connection).to receive_message_chain(:headers, :[]=)
+    allow(mock_faraday_connection).to receive(:post).and_return(mock_response)
+
+    expect {
+      client.checkout.payments_api.payments({})
+    }.to raise_error(Adyen::FormatError) do |error|
+      expect(error.code).to eq(400)
+      expect(error.msg).to eq('Invalid format or fields')
+      expect(error.response[:errorCode]).to eq('702')
+    end
+  end
+
+  it 'raises FormatError on 422 response and checks content' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    mock_faraday_connection = double(Faraday::Connection)
+    error_body = {
+      type: "https://docs.adyen.com/errors/validation",
+      title: "The request is missing required fields or contains invalid data.",
+      status: 422,
+      detail: "It is mandatory to specify a legalEntityId when creating a new account holder.",
+      invalidFields: [{ "name" => "legalEntityId", "message" => "legalEntityId is not provided" }],
+      errorCode: "30_011"
+    }
+    mock_response = Faraday::Response.new(status: 422, body: error_body)
+
+    allow(Faraday).to receive(:new).and_return(mock_faraday_connection)
+    allow(mock_faraday_connection).to receive_message_chain(:headers, :[]=)
+    allow(mock_faraday_connection).to receive(:post).and_return(mock_response)
+
+    expect {
+      client.checkout.payments_api.payments({})
+    }.to raise_error(Adyen::ValidationError) do |error|
+      expect(error.code).to eq(422)
+      expect(error.msg).to eq('Validation error')
+      expect(error.response[:errorCode]).to eq('30_011')
+    end
+  end
+  
 end