BIN Lookup API: Specify version. (#108)

Following a recent PR to add support for the BINLookup API, it seems
I've forgot to specify the API version. this caused call failures as the
BINLookup API only supports v40/v50 versions while the default version
is v49.

Author: ohadbenita

Adyen/client.py

@@ -108,6 +108,8 @@ def _determine_api_url(platform, service, action):
             api_version = settings.API_RECURRING_VERSION
         elif service == "Payout":
             api_version = settings.API_PAYOUT_VERSION
+        elif service == "BinLookup":
+            api_version = settings.API_BIN_LOOKUP_VERSION
         else:
             api_version = settings.API_PAYMENT_VERSION
         return '/'.join([base_uri, service, api_version, action])

Adyen/settings.py

@@ -4,6 +4,7 @@
 ENDPOINT_CHECKOUT_TEST = "https://checkout-test.adyen.com"
 ENDPOINT_CHECKOUT_LIVE_SUFFIX = "https://{}-checkout-live" \
                                 ".adyenpayments.com/checkout"
+API_BIN_LOOKUP_VERSION = "v50"
 API_CHECKOUT_VERSION = "v49"
 API_CHECKOUT_UTILITY_VERSION = "v1"
 API_RECURRING_VERSION = "v25"

test/mocks/BinLookupTest.py

@@ -1,6 +1,14 @@
-import Adyen
+from unittest.mock import ANY
 import unittest
+
 from BaseTest import BaseTest
+import Adyen
+
+
+REQUEST_KWARGS = {
+    'merchantAccount': 'YourMerchantAccount',
+    'amount': '1000'
+}
 
 
 class TestBinLookup(unittest.TestCase):
@@ -14,11 +22,7 @@ class TestBinLookup(unittest.TestCase):
     client.app_name = "appname"
 
     def test_get_cost_estimate_success(self):
-        request = {
-            'merchantAccount': 'YourMerchantAccount',
-            'amount': '1000'
-        }
-
+        self.ady.client.http_client.request.reset_mock()
         expected = {
             'cardBin': {
                 'bin': '458012',
@@ -39,29 +43,40 @@ def test_get_cost_estimate_success(self):
 
         self.ady.client = self.test.create_client_from_file(
             status=200,
-            request=request,
+            request=REQUEST_KWARGS,
             filename='test/mocks/binlookup/getcostestimate-success.json'
         )
 
-        result = self.ady.binlookup.get_cost_estimate(request)
+        result = self.ady.binlookup.get_cost_estimate(REQUEST_KWARGS)
         self.assertEqual(expected, result.message)
+        self.ady.client.http_client.request.assert_called_once_with(
+            'https://pal-test.adyen.com/pal/servlet/'
+            'BinLookup/v50/getCostEstimate',
+            headers={},
+            json={
+                'merchantAccount': 'YourMerchantAccount',
+                'amount': '1000', 'applicationInfo': {
+                    'adyenLibrary': {
+                        'name': 'adyen-python-api-library',
+                        'version': ANY
+                    }
+                }
+            },
+            password='YourWSPassword',
+            username='YourWSUser'
+        )
 
     def test_get_cost_estimate_error_mocked(self):
-        request = {
-            'merchantAccount': 'YourMerchantAccount',
-            'amount': '1000'
-        }
-
         self.ady.client = self.test.create_client_from_file(
             status=200,
-            request=request,
+            request=REQUEST_KWARGS,
             filename=(
                 "test/mocks/binlookup/"
                 "getcostestimate-error-invalid-data-422.json"
             )
         )
 
-        result = self.ady.binlookup.get_cost_estimate(request)
+        result = self.ady.binlookup.get_cost_estimate(REQUEST_KWARGS)
         self.assertEqual(422, result.message['status'])
         self.assertEqual("101", result.message['errorCode'])
         self.assertEqual("Invalid card number", result.message['message'])