Correct the copy for dict_object (#284)

* Correct the copy for dict_object

* remove extra check

Author: AlexandrosMor

Adyen/util.py

@@ -4,6 +4,8 @@
 import hmac
 import hashlib
 import binascii
+import copy
+
 
 
 def generate_notification_sig(dict_object, hmac_key):
@@ -35,7 +37,7 @@ def generate_notification_sig(dict_object, hmac_key):
 
 
 def is_valid_hmac_notification(dict_object, hmac_key):
-    dict_object = dict_object.copy()
+    dict_object = copy.deepcopy(dict_object) 
 
     if 'notificationItems' in dict_object:
         dict_object = dict_object['notificationItems'][0]['NotificationRequestItem']

test/UtilTest.py

@@ -107,4 +107,29 @@ def test_custom_version(self):
             headers={'adyen-library-name': settings.LIB_NAME, 'adyen-library-version': settings.LIB_VERSION},
             json=request,
             xapikey="YourXapikey"
-        )
+        )
+
+    def test_is_valid_hmac_notification_removes_additional_data(self):
+        notification = {
+                            "live":"false",
+                            "notificationItems":[
+                                {
+                                    "NotificationRequestItem":{
+                                        "additionalData":{
+                                        "hmacSignature":"11aa",
+                                        "fraudResultType":"GREEN",
+                                        "fraudManualReview": "false",
+                                        "totalFraudScore":"75"
+                                        },
+                                        "amount":{
+                                        "currency":"USD",
+                                        "value":10000
+                                        },
+                                        "success":"true"
+                                        
+                                    }
+                                }
+                            ]}
+        is_valid_hmac_notification(notification, "11aa")
+        self.assertIsNotNone(notification['notificationItems'][0]['NotificationRequestItem']['additionalData'])
+