Skip to content

Commit 2c93a54

Browse files
committed
Avoid using inline require
1 parent 5462379 commit 2c93a54

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/httpClient/httpURLConnectionClient.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* See the LICENSE file for more info.
1818
*/
1919

20-
import { ClientRequest, IncomingHttpHeaders, IncomingMessage } from "http";
20+
import { ClientRequest, IncomingHttpHeaders, IncomingMessage, request as httpRequest } from "http";
2121
import { Agent, AgentOptions, request as httpsRequest } from "https";
2222
import { HttpsProxyAgent } from "https-proxy-agent";
2323

@@ -195,7 +195,9 @@ class HttpURLConnectionClient implements ClientInterface {
195195
headers: connectionRequest.getHeaders(),
196196
protocol: url.protocol,
197197
};
198-
const redirectedRequest = (url.protocol === 'https:' ? require('https') : require('http')).request(newRequestOptions);
198+
const clientRequestFn = url.protocol === "https:" ? httpsRequest : httpRequest;
199+
const redirectedRequest: ClientRequest = clientRequestFn(newRequestOptions);
200+
199201
const redirectResponse = this.doRequest(redirectedRequest, json);
200202
return resolve(redirectResponse);
201203
} catch (err) {

0 commit comments

Comments
 (0)