From 4944e8c662b71e366cc659696cd2e7e8ee2d454e Mon Sep 17 00:00:00 2001 From: gcatanese Date: Fri, 7 Nov 2025 16:11:31 +0100 Subject: [PATCH 1/3] Invert order of parameters --- .../TransferLimitsBalanceAccountLevelApi.java | 38 +++++++++---------- ...TransferLimitsBalancePlatformLevelApi.java | 37 +++++++++--------- ...nsferLimitsBalanceAccountLevelApiTest.java | 4 +- ...sferLimitsBalancePlatformLevelApiTest.java | 4 +- 4 files changed, 40 insertions(+), 43 deletions(-) diff --git a/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApi.java b/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApi.java index 1cfbc8142..9d1654de6 100644 --- a/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApi.java +++ b/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApi.java @@ -63,7 +63,6 @@ public TransferLimitsBalanceAccountLevelApi(Client client, String baseURL) { * * @param id {@link String } The unique identifier of the balance account. (required) * @param approveTransferLimitRequest {@link ApproveTransferLimitRequest } (required) - * @param approveTransferLimitRequest {@link ApproveTransferLimitRequest } (required) * @throws ApiException if fails to make API call */ public void approvePendingTransferLimits( @@ -104,7 +103,6 @@ public void approvePendingTransferLimits( * * @param id {@link String } The unique identifier of the balance account. (required) * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required) - * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ @@ -147,37 +145,37 @@ public TransferLimit createTransferLimit( /** * Delete a scheduled or pending transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance account. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @throws ApiException if fails to make API call */ - public void deletePendingTransferLimit(String transferLimitId, String id) + public void deletePendingTransferLimit(String id, String transferLimitId) throws ApiException, IOException { - deletePendingTransferLimit(transferLimitId, id, null); + deletePendingTransferLimit(id, transferLimitId, null); } /** * Delete a scheduled or pending transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance account. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param requestOptions {@link RequestOptions } Object to store additional data such as * idempotency-keys (optional) * @throws ApiException if fails to make API call */ public void deletePendingTransferLimit( - String transferLimitId, String id, RequestOptions requestOptions) + String id, String transferLimitId, RequestOptions requestOptions) throws ApiException, IOException { // Add path params Map pathParams = new HashMap<>(); - if (transferLimitId == null) { - throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); - } - pathParams.put("transferLimitId", transferLimitId); if (id == null) { throw new IllegalArgumentException("Please provide the id path parameter"); } pathParams.put("id", id); + if (transferLimitId == null) { + throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); + } + pathParams.put("transferLimitId", transferLimitId); String requestBody = null; Resource resource = @@ -245,39 +243,39 @@ public TransferLimitListResponse getCurrentTransferLimits( /** * Get the details of a transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance account. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ - public TransferLimit getSpecificTransferLimit(String transferLimitId, String id) + public TransferLimit getSpecificTransferLimit(String id, String transferLimitId) throws ApiException, IOException { - return getSpecificTransferLimit(transferLimitId, id, null); + return getSpecificTransferLimit(id, transferLimitId, null); } /** * Get the details of a transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance account. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param requestOptions {@link RequestOptions } Object to store additional data such as * idempotency-keys (optional) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ public TransferLimit getSpecificTransferLimit( - String transferLimitId, String id, RequestOptions requestOptions) + String id, String transferLimitId, RequestOptions requestOptions) throws ApiException, IOException { // Add path params Map pathParams = new HashMap<>(); - if (transferLimitId == null) { - throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); - } - pathParams.put("transferLimitId", transferLimitId); if (id == null) { throw new IllegalArgumentException("Please provide the id path parameter"); } pathParams.put("id", id); + if (transferLimitId == null) { + throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); + } + pathParams.put("transferLimitId", transferLimitId); String requestBody = null; Resource resource = diff --git a/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApi.java b/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApi.java index 5bd78f709..e44072094 100644 --- a/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApi.java +++ b/src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApi.java @@ -63,7 +63,6 @@ public TransferLimitsBalancePlatformLevelApi(Client client, String baseURL) { * * @param id {@link String } The unique identifier of the balance platform. (required) * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required) - * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ @@ -106,37 +105,37 @@ public TransferLimit createTransferLimit( /** * Delete a scheduled or pending transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance platform. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @throws ApiException if fails to make API call */ - public void deletePendingTransferLimit(String transferLimitId, String id) + public void deletePendingTransferLimit(String id, String transferLimitId) throws ApiException, IOException { - deletePendingTransferLimit(transferLimitId, id, null); + deletePendingTransferLimit(id, transferLimitId, null); } /** * Delete a scheduled or pending transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance platform. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param requestOptions {@link RequestOptions } Object to store additional data such as * idempotency-keys (optional) * @throws ApiException if fails to make API call */ public void deletePendingTransferLimit( - String transferLimitId, String id, RequestOptions requestOptions) + String id, String transferLimitId, RequestOptions requestOptions) throws ApiException, IOException { // Add path params Map pathParams = new HashMap<>(); - if (transferLimitId == null) { - throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); - } - pathParams.put("transferLimitId", transferLimitId); if (id == null) { throw new IllegalArgumentException("Please provide the id path parameter"); } pathParams.put("id", id); + if (transferLimitId == null) { + throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); + } + pathParams.put("transferLimitId", transferLimitId); String requestBody = null; Resource resource = @@ -148,39 +147,39 @@ public void deletePendingTransferLimit( /** * Get the details of a transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance platform. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ - public TransferLimit getSpecificTransferLimit(String transferLimitId, String id) + public TransferLimit getSpecificTransferLimit(String id, String transferLimitId) throws ApiException, IOException { - return getSpecificTransferLimit(transferLimitId, id, null); + return getSpecificTransferLimit(id, transferLimitId, null); } /** * Get the details of a transfer limit * - * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param id {@link String } The unique identifier of the balance platform. (required) + * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required) * @param requestOptions {@link RequestOptions } Object to store additional data such as * idempotency-keys (optional) * @return {@link TransferLimit } * @throws ApiException if fails to make API call */ public TransferLimit getSpecificTransferLimit( - String transferLimitId, String id, RequestOptions requestOptions) + String id, String transferLimitId, RequestOptions requestOptions) throws ApiException, IOException { // Add path params Map pathParams = new HashMap<>(); - if (transferLimitId == null) { - throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); - } - pathParams.put("transferLimitId", transferLimitId); if (id == null) { throw new IllegalArgumentException("Please provide the id path parameter"); } pathParams.put("id", id); + if (transferLimitId == null) { + throw new IllegalArgumentException("Please provide the transferLimitId path parameter"); + } + pathParams.put("transferLimitId", transferLimitId); String requestBody = null; Resource resource = diff --git a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApiTest.java b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApiTest.java index 87205a123..c59d2b561 100644 --- a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApiTest.java +++ b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApiTest.java @@ -85,7 +85,7 @@ public void deletePendingTransferLimitTest() throws Exception { String balanceAccountId = "BA12345677890"; String transferLimitId = "TRLI00000000000000000000000001"; - service.deletePendingTransferLimit(transferLimitId, balanceAccountId); + service.deletePendingTransferLimit(balanceAccountId, transferLimitId); verify(client.getHttpClient()) .request( "https://balanceplatform-api-test.adyen.com/bcl/v2/balanceAccounts/BA12345677890/transferLimits/TRLI00000000000000000000000001", @@ -152,7 +152,7 @@ public void getSpecificTransferLimitTest() throws Exception { String transferLimitId = "TRLI00000000000000000000000001"; TransferLimit transferLimit = - service.getSpecificTransferLimit(transferLimitId, balanceAccountId); + service.getSpecificTransferLimit(balanceAccountId, transferLimitId); verify(client.getHttpClient()) .request( diff --git a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java index 0c1350df5..f22622e1f 100644 --- a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java +++ b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java @@ -67,7 +67,7 @@ public void deletePendingTransferLimitTest() throws Exception { String transferLimitId = "TRLI00000000000000000000000001"; String balanceAccountId = "BA12345677890"; - service.deletePendingTransferLimit(transferLimitId, balanceAccountId); + service.deletePendingTransferLimit(balanceAccountId, transferLimitId); verify(client.getHttpClient()) .request( @@ -89,7 +89,7 @@ public void getSpecificTransferLimitTest() throws Exception { String transferLimitId = "TRLI00000000000000000000000001"; TransferLimit transferLimit = - service.getSpecificTransferLimit(transferLimitId, balanceAccountId); + service.getSpecificTransferLimit(balanceAccountId, transferLimitId); verify(client.getHttpClient()) .request( From 3b322a34543021b7585bec857642bbdcff7cd81e Mon Sep 17 00:00:00 2001 From: gcatanese Date: Fri, 7 Nov 2025 16:14:48 +0100 Subject: [PATCH 2/3] Rename variables --- ...sferLimitsBalancePlatformLevelApiTest.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java index f22622e1f..d698c10ad 100644 --- a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java +++ b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java @@ -31,7 +31,7 @@ public void createTransferLimitTest() throws Exception { TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balanceAccountId = "BA12345677890"; + String balancePlatform = "MY_BALANCE_PLATFORM"; CreateTransferLimitRequest createTransferLimitRequest = new CreateTransferLimitRequest() .amount(new Amount().value(10000L).currency("EUR")) @@ -43,11 +43,11 @@ public void createTransferLimitTest() throws Exception { .transferType(TransferType.ALL); TransferLimit transferLimit = - service.createTransferLimit(balanceAccountId, createTransferLimitRequest); + service.createTransferLimit(balancePlatform, createTransferLimitRequest); verify(client.getHttpClient()) .request( - "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits", + "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits", createTransferLimitRequest.toJson(), client.getConfig(), false, @@ -64,14 +64,14 @@ public void deletePendingTransferLimitTest() throws Exception { TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); + String balancePlatform = "MY_BALANCE_PLATFORM"; String transferLimitId = "TRLI00000000000000000000000001"; - String balanceAccountId = "BA12345677890"; - service.deletePendingTransferLimit(balanceAccountId, transferLimitId); + service.deletePendingTransferLimit(balancePlatform, transferLimitId); verify(client.getHttpClient()) .request( - "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits/TRLI00000000000000000000000001", + "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits/TRLI00000000000000000000000001", null, client.getConfig(), false, @@ -85,15 +85,15 @@ public void getSpecificTransferLimitTest() throws Exception { Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimit.json"); TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balanceAccountId = "BA12345677890"; + String balancePlatform = "MY_BALANCE_PLATFORM"; String transferLimitId = "TRLI00000000000000000000000001"; TransferLimit transferLimit = - service.getSpecificTransferLimit(balanceAccountId, transferLimitId); + service.getSpecificTransferLimit(balancePlatform, transferLimitId); verify(client.getHttpClient()) .request( - "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits/TRLI00000000000000000000000001", + "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits/TRLI00000000000000000000000001", null, client.getConfig(), false, @@ -109,13 +109,13 @@ public void getTransferLimitsTest() throws Exception { Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimits.json"); TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balanceAccountId = "BA12345677890"; + String balancePlatform = "MY_BALANCE_PLATFORM"; - TransferLimitListResponse transferLimits = service.getTransferLimits(balanceAccountId); + TransferLimitListResponse transferLimits = service.getTransferLimits(balancePlatform); verify(client.getHttpClient()) .request( - "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits", + "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits", null, client.getConfig(), false, From e1a7709138cc24fe7acc38d4e1d808e323c315f9 Mon Sep 17 00:00:00 2001 From: gcatanese Date: Fri, 7 Nov 2025 16:22:23 +0100 Subject: [PATCH 3/3] Code format --- .../TransferLimitsBalancePlatformLevelApiTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java index d698c10ad..af9da997c 100644 --- a/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java +++ b/src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java @@ -64,7 +64,7 @@ public void deletePendingTransferLimitTest() throws Exception { TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balancePlatform = "MY_BALANCE_PLATFORM"; + String balancePlatform = "MY_BALANCE_PLATFORM"; String transferLimitId = "TRLI00000000000000000000000001"; service.deletePendingTransferLimit(balancePlatform, transferLimitId); @@ -85,7 +85,7 @@ public void getSpecificTransferLimitTest() throws Exception { Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimit.json"); TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balancePlatform = "MY_BALANCE_PLATFORM"; + String balancePlatform = "MY_BALANCE_PLATFORM"; String transferLimitId = "TRLI00000000000000000000000001"; TransferLimit transferLimit = @@ -109,7 +109,7 @@ public void getTransferLimitsTest() throws Exception { Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimits.json"); TransferLimitsBalancePlatformLevelApi service = new TransferLimitsBalancePlatformLevelApi(client); - String balancePlatform = "MY_BALANCE_PLATFORM"; + String balancePlatform = "MY_BALANCE_PLATFORM"; TransferLimitListResponse transferLimits = service.getTransferLimits(balancePlatform);