Improve Terminal API test (#1573)

Author: gcatanese

src/test/java/com/adyen/BaseTest.java

@@ -32,15 +32,7 @@
 import com.adyen.httpclient.AdyenHttpClient;
 import com.adyen.httpclient.HTTPClientException;
 import com.adyen.model.additionalData.InvoiceLine;
-import com.adyen.model.nexo.AmountsReq;
-import com.adyen.model.nexo.MessageCategoryType;
-import com.adyen.model.nexo.MessageClassType;
-import com.adyen.model.nexo.MessageHeader;
-import com.adyen.model.nexo.MessageType;
-import com.adyen.model.nexo.PaymentTransaction;
-import com.adyen.model.nexo.SaleData;
-import com.adyen.model.nexo.SaleToPOIRequest;
-import com.adyen.model.nexo.TransactionIdentification;
+import com.adyen.model.nexo.*;
 import com.adyen.model.payment.ApplicationInfo;
 import com.adyen.model.payment.AuthenticationResultRequest;
 import com.adyen.model.payment.BrowserInfo;
@@ -368,6 +360,38 @@ protected TerminalAPIRequest createTerminalAPIPaymentRequest()
     return terminalAPIRequest;
   }
 
+  protected TerminalAPIRequest createTerminalAPIInputRequest()
+      throws DatatypeConfigurationException {
+    SaleToPOIRequest saleToPOIRequest = new SaleToPOIRequest();
+
+    MessageHeader messageHeader = new MessageHeader();
+    messageHeader.setProtocolVersion("3.0");
+    messageHeader.setMessageClass(MessageClassType.DEVICE);
+    messageHeader.setMessageCategory(MessageCategoryType.INPUT);
+    messageHeader.setMessageType(MessageType.REQUEST);
+    messageHeader.setSaleID("001");
+    messageHeader.setServiceID("001");
+    messageHeader.setPOIID("P400Plus-123456789");
+
+    saleToPOIRequest.setMessageHeader(messageHeader);
+
+    com.adyen.model.nexo.InputRequest inputRequest = new com.adyen.model.nexo.InputRequest();
+    DisplayOutput displayOutput = new DisplayOutput();
+    OutputContent outputContent = new OutputContent();
+    PredefinedContent predefinedContent = new PredefinedContent();
+    predefinedContent.setReferenceID("GetSignature");
+    outputContent.setPredefinedContent(predefinedContent);
+    displayOutput.setOutputContent(outputContent);
+    inputRequest.setDisplayOutput(displayOutput);
+
+    saleToPOIRequest.setInputRequest(inputRequest);
+
+    TerminalAPIRequest terminalAPIRequest = new TerminalAPIRequest();
+    terminalAPIRequest.setSaleToPOIRequest(saleToPOIRequest);
+
+    return terminalAPIRequest;
+  }
+
   protected AuthenticationResultRequest createAuthenticationResultRequest() {
     AuthenticationResultRequest authenticationResultRequest = new AuthenticationResultRequest();
     authenticationResultRequest.setMerchantAccount("AMerchant");

src/test/java/com/adyen/TerminalCloudAPITest.java

@@ -21,7 +21,12 @@
 package com.adyen;
 
 import static org.junit.Assert.*;
+import static org.mockito.ArgumentMatchers.*;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.ArgumentMatchers.isNull;
+import static org.mockito.Mockito.verify;
 
+import com.adyen.constants.ApiConstants;
 import com.adyen.model.nexo.MessageCategoryType;
 import com.adyen.model.nexo.MessageClassType;
 import com.adyen.model.nexo.MessageHeader;
@@ -45,6 +50,7 @@
 import java.math.BigDecimal;
 import java.util.List;
 import org.junit.Test;
+import org.mockito.ArgumentCaptor;
 
 /** Tests for /sync and /async */
 public class TerminalCloudAPITest extends BaseTest {
@@ -166,6 +172,23 @@ public void syncPaymentRequestSuccess() throws Exception {
         paymentResult.getCurrencyConversion().get(0).getConvertedAmount().getAmountValue());
     assertEquals(
         "EUR", paymentResult.getCurrencyConversion().get(0).getConvertedAmount().getCurrency());
+
+    final ArgumentCaptor<String> captor = ArgumentCaptor.forClass(String.class);
+    verify(client.getHttpClient())
+        .request(
+            isNotNull(),
+            captor.capture(),
+            any(com.adyen.Config.class),
+            eq(true),
+            isNull(),
+            eq(ApiConstants.HttpMethod.POST),
+            isNull());
+
+    String requestAsJson = captor.getValue();
+    assertTrue(
+        "SaleToAcquirerData field not found", requestAsJson.contains("\"SaleToAcquirerData\":"));
+    assertFalse("Found null value", requestAsJson.contains(":null"));
+    assertFalse("Found null value", requestAsJson.contains(": null"));
   }
 
   /** Test success flow for POST /sync that includes unexpected attributes */
@@ -230,7 +253,9 @@ public void syncInputRequestSuccess() throws Exception {
     Client client = createMockClientFromFile("mocks/terminal-api/input-request-success.json");
     TerminalCloudAPI terminalCloudApi = new TerminalCloudAPI(client);
 
-    TerminalAPIResponse requestResponse = terminalCloudApi.sync(new TerminalAPIRequest());
+    TerminalAPIRequest inputRequest = createTerminalAPIInputRequest();
+
+    TerminalAPIResponse requestResponse = terminalCloudApi.sync(inputRequest);
 
     assertNotNull(requestResponse);
     assertNotNull(requestResponse.getSaleToPOIResponse());
@@ -254,6 +279,24 @@ public void syncInputRequestSuccess() throws Exception {
             .getInput()
             .getMenuEntryNumber()
             .length);
+
+    final ArgumentCaptor<String> captor = ArgumentCaptor.forClass(String.class);
+    verify(client.getHttpClient())
+        .request(
+            isNotNull(),
+            captor.capture(),
+            any(com.adyen.Config.class),
+            eq(true),
+            isNull(),
+            eq(ApiConstants.HttpMethod.POST),
+            isNull());
+
+    String requestAsJson = captor.getValue();
+    assertTrue("InputRequest field not found", requestAsJson.contains("\"InputRequest\":"));
+    assertTrue(
+        "PredefinedContent field not found", requestAsJson.contains("\"PredefinedContent\":"));
+    assertFalse("Found null value", requestAsJson.contains(":null"));
+    assertFalse("Found null value", requestAsJson.contains(": null"));
   }
 
   /** Mocked response for stored value type for POST /sync */