Enable warnings and fix detected warnings.

Author: godunko

gnat/gnatdoc.gpr

@@ -33,7 +33,7 @@ project GNATdoc is
    for Main use ("gnatdoc-driver.adb");
 
    package Compiler is
-      for Switches ("Ada") use ("-g", "-gnatygO", "-gnata");
+      for Switches ("Ada") use ("-g", "-gnatygO", "-gnata", "-gnatwa");
    end Compiler;
 
    package Builder is

gnat/libgnatdoc.gpr

@@ -25,7 +25,7 @@ project LibGNATdoc is
    for Source_Dirs use ("../source");
 
    package Compiler is
-      for Switches ("Ada") use ("-g", "-gnatygO", "-gnata");
+      for Switches ("Ada") use ("-g", "-gnatygO", "-gnata", "-gnatwa");
    end Compiler;
 
 end LibGNATdoc;

source/backend/gnatdoc-backend-html.adb

@@ -30,7 +30,6 @@ with VSS.Strings.Conversions;
 with VSS.String_Vectors;
 with VSS.XML.Templates.Processors;
 with VSS.XML.Templates.Proxies.Strings;
-with VSS.XML.Templates.Values;
 with VSS.XML.XmlAda_Readers;
 
 with GNATdoc.Comments.Helpers;
@@ -43,7 +42,6 @@ package body GNATdoc.Backend.HTML is
 
    use GNAT.SHA256;
    use GNATCOLL.VFS;
-   use GNATdoc.Comments.Helpers;
    use GNATdoc.Entities;
    use VSS.Strings.Conversions;
 
@@ -91,12 +89,8 @@ package body GNATdoc.Backend.HTML is
 
    package body Proxies is
 
-      use type VSS.String_Vectors.Virtual_String_Vector;
       use type VSS.Strings.Virtual_String;
 
-      type Entity_Information_Set_Proxy_Access is
-        access all Entity_Information_Set_Proxy;
-
       type TOC_Iterator is
         limited new VSS.XML.Templates.Proxies.Abstract_Proxy
           and VSS.XML.Templates.Proxies.Abstract_Iterable_Iterator
@@ -417,11 +411,8 @@ package body GNATdoc.Backend.HTML is
      (Self   : in out HTML_Backend'Class;
       Entity : not null Entity_Information_Access)
    is
-      Name       : constant String :=
+      Name : constant String :=
         Digest (To_UTF_8_String (Entity.Signature)) & ".html";
-      File       : Writable_File :=
-        Create (Filesystem_String (Name)).Write_File;
-      All_Nested : Entity_Information_Sets.Set;
 
    begin
       declare

source/backend/gnatdoc-backend-html_markup.adb

@@ -16,7 +16,6 @@
 ------------------------------------------------------------------------------
 
 with VSS.XML.Events;
-with VSS.XML.Event_Vectors;
 with VSS.XML.Namespaces;
 
 with Markdown.Block_Containers;

source/backend/streams.adb

@@ -15,8 +15,6 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
-with Ada.Streams;
-
 with VSS.Stream_Element_Vectors.Conversions;
 
 package body Streams is
@@ -51,12 +49,15 @@ package body Streams is
       Item    : VSS.Characters.Virtual_Character;
       Success : in out Boolean)
    is
+      pragma Unreferenced (Success);
+
       Data : constant String :=
         VSS.Stream_Element_Vectors.Conversions.Unchecked_To_String
           (Self.Encoder.Encode (Item));
 
    begin
       GNATCOLL.VFS.Write (Self.Writable, Data);
+      --  Note, any errors are reported at the time of file close only.
    end Put;
 
 end Streams;

source/frontend/gnatdoc-frontend.adb

@@ -16,21 +16,18 @@
 ------------------------------------------------------------------------------
 
 with Ada.Text_IO;
-with Ada.Wide_Wide_Text_IO;
 
 with Libadalang.Common;
 
 with VSS.Strings.Conversions;
 
 with GNATdoc.Comments.Extractor;
-with GNATdoc.Comments.Options;
 with GNATdoc.Entities;
 with GNATdoc.Options;
 
 package body GNATdoc.Frontend is
 
    use GNATdoc.Comments.Extractor;
-   use GNATdoc.Comments.Options;
    use Libadalang.Analysis;
    use Libadalang.Common;
    use VSS.Strings;

source/gnatdoc-comments-builders-subprograms.adb

@@ -15,8 +15,6 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
-with Libadalang.Common;
-
 package body GNATdoc.Comments.Builders.Subprograms is
 
    use Libadalang.Analysis;

source/gnatdoc-comments-builders.adb

@@ -38,8 +38,7 @@ package body GNATdoc.Comments.Builders is
       Node    : Basic_Decl'Class;
       Pattern : VSS.Regular_Expressions.Regular_Expression)
    is
-      Node_Location : constant Source_Location_Range := Node.Sloc_Range;
-      Location      : Source_Location_Range;
+      Location : Source_Location_Range;
 
    begin
       --  Extract comments inside the declaration and fill text of raw,

source/gnatdoc-comments-extractor.adb

@@ -452,7 +452,7 @@ package body GNATdoc.Comments.Extractor is
       Options : GNATdoc.Comments.Options.Extractor_Options)
       return not null Structured_Comment_Access is
    begin
-      return Result : not null Structured_Comment_Access :=
+      return Result : constant not null Structured_Comment_Access :=
         new Structured_Comment
       do
          Extract (Node, Options, Result.all);
@@ -1201,9 +1201,9 @@ package body GNATdoc.Comments.Extractor is
       Options       : GNATdoc.Comments.Options.Extractor_Options;
       Documentation : in out Structured_Comment'Class)
    is
-      Definition       : Libadalang.Analysis.Task_Def'Class :=
-        Decl.F_Definition;
-      Is_Or_With_Token : Token_Reference;
+      Definition                 : constant
+        Libadalang.Analysis.Task_Def'Class := Decl.F_Definition;
+      Is_Or_With_Token           : Token_Reference;
 
       Leading_Section            : Section_Access;
       Trailing_Section           : Section_Access;
@@ -1636,9 +1636,9 @@ package body GNATdoc.Comments.Extractor is
          Line_Index : Positive;
          Amount     : VSS.Strings.Character_Count)
       is
-         Line      : Virtual_String     := Text (Line_Index);
-         Iterator  : Character_Iterator := Line.At_First_Character;
-         Count     : Character_Count    := Amount;
+         Line      : constant Virtual_String := Text (Line_Index);
+         Iterator  : Character_Iterator      := Line.At_First_Character;
+         Count     : Character_Count         := Amount;
 
       begin
          while Iterator.Forward loop
@@ -2075,7 +2075,7 @@ package body GNATdoc.Comments.Extractor is
 
                         else
                            declare
-                              Match : Regular_Expression_Match :=
+                              Match : constant Regular_Expression_Match :=
                                 Pattern.Match (Line);
 
                            begin
@@ -2106,7 +2106,7 @@ package body GNATdoc.Comments.Extractor is
                        Section.Text (J);
                      Iterator : Character_Iterator :=
                        Line.At_First_Character;
-                     Success  : Boolean;
+                     Success  : Boolean with Unreferenced;
 
                   begin
                      if Line.Character_Length > Indent then

source/gnatdoc-comments-helpers.ads

@@ -16,7 +16,6 @@
 ------------------------------------------------------------------------------
 
 with VSS.String_Vectors;
-with VSS.Strings;
 
 with Libadalang.Analysis;