Review Windows implementation of Stat to include missing fields.

Change-Id: I8279590f33589af3e75d25879147c71cc81424dd

Author: Nikokrock

src/os/gnatcoll-os-stat-stat__win32.adb

@@ -24,37 +24,63 @@
 with GNATCOLL.OS.Win32.Files; use GNATCOLL.OS.Win32.Files;
 with GNATCOLL.OS.Win32; use GNATCOLL.OS.Win32;
 with GNAT.OS_Lib;
+with Ada.Calendar.Conversions;
+with Interfaces.C;
 
 separate (GNATCOLL.OS.Stat)
 function Stat
-   (Path : UTF8.UTF_8_String;
+   (Path            : UTF8.UTF_8_String;
     Follow_Symlinks : Boolean := True)
-   return File_Attributes is
-   Attr        : FILE_OBJECT_ATTRIBUTES;
-   Status      : NTSTATUS;
-   Information : FILE_BASIC_INFORMATION;
-   Result      : File_Attributes;
-
+   return File_Attributes
+is
+   Attr      : UNICODE_PATH;
+   Status    : NTSTATUS;
+   Info      : FILE_ALL_INFORMATION;
+   Result    : File_Attributes;
+   WinHandle : HANDLE := NULL_HANDLE;
+   IO        : IO_STATUS_BLOCK;
    pragma Unreferenced (Follow_Symlinks);
 
 begin
    --  NtQueryAttributesFile requires an absolute path
-   if GNAT.OS_Lib.Is_Absolute_Path (Path) then
-      Initialize (Attr, Path);
-   else
-      Initialize (Attr, GNAT.OS_Lib.Normalize_Pathname (Path));
-   end if;
+   Initialize (Attr, GNAT.OS_Lib.Normalize_Pathname (Path));
 
-   Status := NtQueryAttributesFile (Attr.OA, Information);
+   Status := NtOpenFile
+      (WinHandle,
+       Attr.Str,
+       FILE_READ_ATTRIBUTES,
+       IO,
+       SHARE_ALL,
+       FILE_OPEN_FOR_BACKUP_INTENT);
+   if not Is_Success (Status) then
+      Result.Exists := False;
+      return Result;
+   end if;
+   WinHandle := WinHandle and 16#FFFFFFFF#;
 
+   Status := NtQueryInformationFile (WinHandle, IO, LPVOID (Info'Address),
+                                     FILE_ALL_INFORMATION'Size / 8,
+                                     FileAllInformation);
    if Is_Success (Status) then
       Result.Exists := True;
-      Result.Directory := (DIRECTORY and Information.FileAttributes) > 0;
+      Result.Directory :=
+         (DIRECTORY and Info.BasicInformation.FileAttributes) > 0;
       Result.Symbolic_Link :=
-         (REPARSE_POINT and Information.FileAttributes) > 0;
+         (REPARSE_POINT and Info.BasicInformation.FileAttributes) > 0;
       Result.Regular :=
          not (Result.Directory or Result.Symbolic_Link);
+      Result.Stamp := Ada.Calendar.Conversions.To_Ada_Time
+         (Interfaces.C.long
+            ((Info.BasicInformation.LastWriteTime / 10000000)
+            - Win32_Epoch_Offset));
+      Result.Length := Info.StandardInformation.EndOfFile;
+      Result.Executable := True;
+      Result.Readable   := True;
+      Result.Writable   := True;
+   else
+      Result.Exists := False;
    end if;
 
+   Status := NtClose (WinHandle);
    return Result;
 end Stat;

testsuite/tests/os/stat/test.adb

@@ -15,6 +15,7 @@ begin
    IO.Put_Line ("GNATCOLL.OS.Stat test");
    declare
       FA : File_Attributes;
+      D  : Duration;
    begin
       FA := Stat ("directory");
       IO.Put_Line (Image (FA));
@@ -31,7 +32,11 @@ begin
                 Msg => "check that regular_file is not a dir");
       A.Assert (not Is_Symbolic_Link (FA),
                 Msg => "check that regular_file is not a symbolic link");
-      A.Assert (Clock - Modification_Time (FA) < 100.0);
+      D := Clock - Modification_Time (FA);
+      A.Assert
+         (D < 100.0,
+          Msg => "check that modification time is less than 100s in the past: "
+          & D'Img);
 
       IO.Put_Line ("test file with utf-8 name");
       FA := Stat (Character'Val (16#C3#) & Character'Val (16#A9#) & ".txt");