Fix logic in __gnatcoll_wait_for_sigchld

Jugst3r · Jugst3r · commit 2d68d3d0644a · 2024-04-02T11:50:52.000+02:00
We were not passing a NULL struct timeval pointer in the case of an
infinite timeout.
diff --git a/src/os/unix/process-wrappers.c b/src/os/unix/process-wrappers.c
@@ -104,7 +104,7 @@ int __gnatcoll_wait_for_sigchld (int fd, sint_64 timeout)
    }
 
    while (tv.tv_sec > 0 || tv.tv_usec > 0) {
-      retval = select(fd + 1, &fd_list, NULL, NULL, &tv);
+      retval = select(fd + 1, &fd_list, NULL, NULL, effective_timeout);
       if (retval > 0)
       {
          read (fd, buf, 1);

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ int __gnatcoll_wait_for_sigchld (int fd, sint_64 timeout)`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`while (tv.tv_sec > 0 \|\| tv.tv_usec > 0) {`
`107`		`- retval = select(fd + 1, &fd_list, NULL, NULL, &tv);`
	`107`	`+ retval = select(fd + 1, &fd_list, NULL, NULL, effective_timeout);`
`108`	`108`	`if (retval > 0)`
`109`	`109`	`{`
`110`	`110`	`read (fd, buf, 1);`