Skip to content

Commit 1e1ccf0

Browse files
committed
Adjust documentation and parameters name of Open_Pipe
Change-Id: Ifca6a3a96bc003d08c8ed5c0aceb074ed6081c1b
1 parent f994a03 commit 1e1ccf0

File tree

5 files changed

+20
-20
lines changed

5 files changed

+20
-20
lines changed

src/os/gnatcoll-os-fs-open_pipe__linux.adb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ with GNATCOLL.OS.Libc;
2525

2626
separate (GNATCOLL.OS.FS)
2727
procedure Open_Pipe
28-
(Pipe_Input : out File_Descriptor;
29-
Pipe_Output : out File_Descriptor)
28+
(Pipe_Read : out File_Descriptor;
29+
Pipe_Write : out File_Descriptor)
3030
is
3131
package Libc renames GNATCOLL.OS.Libc;
3232

@@ -42,7 +42,7 @@ begin
4242
raise OS_Error with "cannot open pipe";
4343
end if;
4444

45-
Pipe_Input := Result.Input;
46-
Pipe_Output := Result.Output;
45+
Pipe_Read := Result.Input;
46+
Pipe_Write := Result.Output;
4747

4848
end Open_Pipe;

src/os/gnatcoll-os-fs-open_pipe__unix.adb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ with GNAT.Task_Lock;
2626

2727
separate (GNATCOLL.OS.FS)
2828
procedure Open_Pipe
29-
(Pipe_Input : out File_Descriptor;
30-
Pipe_Output : out File_Descriptor)
29+
(Pipe_Read : out File_Descriptor;
30+
Pipe_Write : out File_Descriptor)
3131
is
3232
package Libc renames GNATCOLL.OS.Libc;
3333

@@ -46,12 +46,12 @@ begin
4646
raise OS_Error with "cannot open pipe";
4747
end if;
4848

49-
Pipe_Input := Result.Input;
50-
Pipe_Output := Result.Output;
49+
Pipe_Read := Result.Input;
50+
Pipe_Write := Result.Output;
5151

5252
begin
53-
Set_Close_On_Exec (Pipe_Input, True);
54-
Set_Close_On_Exec (Pipe_Output, True);
53+
Set_Close_On_Exec (Pipe_Read, True);
54+
Set_Close_On_Exec (Pipe_Write, True);
5555
exception
5656
when OS_Error =>
5757
GNAT.Task_Lock.Unlock;

src/os/gnatcoll-os-fs-open_pipe__win32.adb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ with GNATCOLL.OS.Win32.Files;
2626

2727
separate (GNATCOLL.OS.FS)
2828
procedure Open_Pipe
29-
(Pipe_Input : out File_Descriptor;
30-
Pipe_Output : out File_Descriptor)
29+
(Pipe_Read : out File_Descriptor;
30+
Pipe_Write : out File_Descriptor)
3131
is
3232
package Win32 renames GNATCOLL.OS.Win32;
3333

@@ -46,7 +46,7 @@ begin
4646
raise OS_Error with "cannot open pipe";
4747
end if;
4848

49-
Pipe_Input := Win32.Files.OpenOSFHandle (Read_Pipe);
50-
Pipe_Output := Win32.Files.OpenOSFHandle (Write_Pipe);
49+
Pipe_Read := Win32.Files.OpenOSFHandle (Read_Pipe);
50+
Pipe_Write := Win32.Files.OpenOSFHandle (Write_Pipe);
5151

5252
end Open_Pipe;

src/os/gnatcoll-os-fs.adb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ package body GNATCOLL.OS.FS is
6161
---------------
6262

6363
procedure Open_Pipe
64-
(Pipe_Input : out File_Descriptor;
65-
Pipe_Output : out File_Descriptor) is separate;
64+
(Pipe_Read : out File_Descriptor;
65+
Pipe_Write : out File_Descriptor) is separate;
6666

6767
----------
6868
-- Read --

src/os/gnatcoll-os-fs.ads

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ package GNATCOLL.OS.FS is
6464
-- inherited by a child process)
6565

6666
procedure Open_Pipe
67-
(Pipe_Input : out File_Descriptor;
68-
Pipe_Output : out File_Descriptor);
69-
-- Open a pipe. Data can be written on Pipe_Input and then read on
70-
-- Pipe_Output. OS_Error can be raised in case of error. Note that the pipe
67+
(Pipe_Read : out File_Descriptor;
68+
Pipe_Write : out File_Descriptor);
69+
-- Open a pipe. Data can be written on Pipe_Write and then read on
70+
-- Pipe_Read. OS_Error can be raised in case of error. Note that the pipe
7171
-- is opened with "close on exec" mode.
7272

7373
procedure Set_Close_On_Exec

0 commit comments

Comments
 (0)