Fix linting issues and activate linting in CI

Author: eliericha

Makefile

@@ -128,6 +128,7 @@ ifneq ($(npm_config_offline),true)
 	cd integration/vscode/ada; LD_LIBRARY_PATH= npm install --no-audit
 	cd integration/vscode/ada; LD_LIBRARY_PATH= npm run check-licenses
 endif
+	cd integration/vscode/ada; LD_LIBRARY_PATH= npm run cilint
 	cd integration/vscode/ada; LD_LIBRARY_PATH= npm run compile
 	@echo Now run:
 	@echo code --extensionDevelopmentPath=`pwd`/integration/vscode/ada/ `pwd`

integration/vscode/ada/package.json

@@ -588,6 +588,7 @@
         "watch": "node ./node_modules/typescript/bin/tsc -watch",
         "pretest": "npm run compile",
         "lint": "eslint './src/**/*.{js,ts,tsx}' --quiet --fix",
+        "cilint": "eslint './src/**/*.{js,ts,tsx}'",
         "test": "node ./out/test/runTest.js"
     },
     "dependencies": {

integration/vscode/ada/src/extension.ts

@@ -26,6 +26,7 @@ import {
     ServerOptions,
     SymbolKind,
 } from 'vscode-languageclient/node';
+import { ALSClientFeatures } from './alsClientFeatures';
 import { alsCommandExecutor } from './alsExecuteCommand';
 import GnatTaskProvider, { getEnclosingSymbol } from './gnatTaskProvider';
 import GprTaskProvider from './gprTaskProvider';

integration/vscode/ada/src/gnatTaskProvider.ts

@@ -42,14 +42,16 @@ interface TaskProperties {
  * or '' if not found.
  */
 const limitSubp = async (): Promise<string> => {
-    return getEnclosingSymbol(vscode.window.activeTextEditor, [SymbolKind.Function]).then((Symbol) => {
-        if (Symbol) {
-            const subprogram_line: string = (Symbol.range.start.line + 1).toString();
-            return `--limit-subp=\${fileBasename}:${subprogram_line}`;
-        } else {
-            return '';
+    return getEnclosingSymbol(vscode.window.activeTextEditor, [SymbolKind.Function]).then(
+        (Symbol) => {
+            if (Symbol) {
+                const subprogram_line: string = (Symbol.range.start.line + 1).toString();
+                return `--limit-subp=\${fileBasename}:${subprogram_line}`;
+            } else {
+                return '';
+            }
         }
-    });
+    );
 };
 
 /**
@@ -288,7 +290,7 @@ async function getTasks(): Promise<vscode.Task[]> {
  * to find the closest symbol enclosing the cursor's position.
  * @returns Return the closest enclosing symbol.
  */
-export async function getEnclosingSymbol (
+export async function getEnclosingSymbol(
     editor: vscode.TextEditor | undefined,
     kinds: vscode.SymbolKind[]
 ): Promise<vscode.DocumentSymbol | null> {
@@ -332,7 +334,7 @@ export async function getEnclosingSymbol (
     }
 
     return null;
-};
+}
 
 const getSelectedRegion = (editor: vscode.TextEditor | undefined): string => {
     if (editor) {