Merge pull request #12467 from kjbracey-arm/nsapics

Inline nsapi_create_stack(NetworkStack)

Author: 0xc0170

UNITTESTS/stubs/NetworkStack_stub.cpp

@@ -68,11 +68,6 @@ NetworkStack *nsapi_create_stack(nsapi_stack_t *stack)
     return reinterpret_cast<NetworkStack *>(stack);
 }
 
-NetworkStack *nsapi_create_stack(NetworkStack *stack)
-{
-    return reinterpret_cast<NetworkStack *>(stack);
-}
-
 nsapi_value_or_error_t NetworkStack::gethostbyname_async(const char *host, hostbyname_cb_t callback, nsapi_version_t version,
                                                          const char *interface_name)
 {

features/netsocket/NetworkStack.cpp

@@ -433,8 +433,3 @@ NetworkStack *nsapi_create_stack(nsapi_stack_t *stack)
     return new (stack->_stack_buffer) NetworkStackWrapper;
 }
 
-NetworkStack *nsapi_create_stack(NetworkStack *stack)
-{
-    return stack;
-}
-

features/netsocket/NetworkStack.h

@@ -477,14 +477,18 @@ class NetworkStack : public DNS {
 
 /** Convert a raw nsapi_stack_t object into a C++ NetworkStack object
  *
- *  @param stack    Reference to an object that can be converted to a stack
+ *  @param stack    Pointer to an object that can be converted to a stack
  *                  - A raw nsapi_stack_t object
- *                  - A reference to a network stack
- *                  - A reference to a network interface
- *  @return         Reference to the underlying network stack
+ *                  - A pointer to a network stack
+ *                  - A pointer to a network interface
+ *  @return         Pointer to the underlying network stack
  */
 NetworkStack *nsapi_create_stack(nsapi_stack_t *stack);
-NetworkStack *nsapi_create_stack(NetworkStack *stack);
+
+inline NetworkStack *nsapi_create_stack(NetworkStack *stack)
+{
+    return stack;
+}
 
 template <typename IF>
 NetworkStack *nsapi_create_stack(IF *iface)