Merge pull request #12511 from paul-szczepanek-arm/patch-1

allow reconfiguring a running watchdog

Author: 0xc0170

UNITTESTS/drivers/Watchdog/test_watchdog.cpp

@@ -38,7 +38,6 @@ class TestWatchdog : public testing::Test {
 TEST_F(TestWatchdog, test_watchdog_start_stop_get_timeout)
 {
     EXPECT_TRUE(Watchdog::get_instance().start(500));
-    EXPECT_FALSE(Watchdog::get_instance().start(2000));
     EXPECT_TRUE(Watchdog::get_instance().stop());
     EXPECT_FALSE(Watchdog::get_instance().stop());
     EXPECT_EQ(500, Watchdog::get_instance().get_timeout());

drivers/Watchdog.h

@@ -98,8 +98,8 @@ class Watchdog : private NonCopyable<Watchdog>  {
      * @param timeout Watchdog timeout in milliseconds.
      *
      * @return true if the Watchdog timer was started successfully;
-     *         false if Watchdog timer was not started or if the Watchdog
-     *         timer is already running.
+     *         false if Watchdog timer was not started or if setting
+     *         a new watchdog timeout was not possible.
      */
     bool start(uint32_t timeout);
 

drivers/source/Watchdog.cpp

@@ -34,18 +34,14 @@ bool Watchdog::start(uint32_t timeout)
     MBED_ASSERT(timeout > 0);
 
     core_util_critical_section_enter();
-    if (_running) {
-        core_util_critical_section_exit();
-        return false;
-    }
     watchdog_config_t config;
     config.timeout_ms = timeout;
     watchdog_status_t sts = hal_watchdog_init(&config);
     if (sts == WATCHDOG_STATUS_OK) {
         _running = true;
     }
     core_util_critical_section_exit();
-    return _running;
+    return (sts == WATCHDOG_STATUS_OK);
 }
 
 bool Watchdog::start()