Fix incorrect integer division in analogout_read

Kyle Kearney · Kyle Kearney · commit 1713e79ccfc7 · 2019-09-18T12:06:33.000-07:00
Replace with multiplication by the floating point reciprocal, to produce a floating point result while being more efficient than floating point division. Addresses the issue raised by kjbracey-arm in #11324 (review)
diff --git a/targets/TARGET_Cypress/TARGET_PSOC6/cy_analogout_api.c b/targets/TARGET_Cypress/TARGET_PSOC6/cy_analogout_api.c
@@ -51,7 +51,7 @@ void analogout_write_u16(dac_t *obj, uint16_t value)
 
 float analogout_read(dac_t *obj)
 {
-    return analogout_read_u16(obj) / UINT16_MAX;
+    return analogout_read_u16(obj) * (1.0f / UINT16_MAX);
 }
 
 uint16_t analogout_read_u16(dac_t *obj)

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ void analogout_write_u16(dac_t *obj, uint16_t value)`
`51`	`51`
`52`	`52`	`float analogout_read(dac_t *obj)`
`53`	`53`	`{`
`54`		`- return analogout_read_u16(obj) / UINT16_MAX;`
	`54`	`+ return analogout_read_u16(obj) * (1.0f / UINT16_MAX);`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`uint16_t analogout_read_u16(dac_t *obj)`