Merge pull request #10097 from 0xc0170/rollup

Rollup PRs: simple fixes

Author: 0xc0170

TEST_APPS/device/socket_app/cmd_socket.cpp

@@ -673,6 +673,7 @@ static nsapi_size_or_error_t start_udp_receiver_thread(SInfo *info, int argc, ch
     int *packetSizes = new (nothrow) int[PACKET_SIZE_ARRAY_LEN];
     if (!packetSizes) {
         cmd_printf("Allocation failed\r\n");
+        free(dataIn);
         return CMDLINE_RETCODE_FAIL;
     }
     for (int i = 0; i < PACKET_SIZE_ARRAY_LEN; i++) {

UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/at_cellularnetworktest.cpp

@@ -122,13 +122,15 @@ TEST_F(TestAT_CellularNetwork, test_AT_CellularNetwork_get_registration_params)
     EXPECT_TRUE(reg_params._status == CellularNetwork::RegistrationDenied);
     EXPECT_TRUE(reg_params._act == CellularNetwork::RAT_EGPRS);
     EXPECT_TRUE(reg_params._cell_id == -1);
+    EXPECT_TRUE(reg_params._lac == -1);
 
     ATHandler_stub::read_string_index = 4;
     ATHandler_stub::read_string_table[3] = "00C3";
     ATHandler_stub::read_string_table[2] = "1234FFC1";//==  cellid and in dec: 305463233
     ATHandler_stub::read_string_table[1] = "00100100";
     ATHandler_stub::read_string_table[0] = "01000111";
     EXPECT_TRUE(NSAPI_ERROR_OK == cn.get_registration_params(CellularNetwork::C_EREG, reg_params));
+    EXPECT_TRUE(reg_params._lac == 0xc3);
     EXPECT_TRUE(reg_params._cell_id == 305463233);
     EXPECT_TRUE(reg_params._active_time == 240);
     EXPECT_TRUE(reg_params._periodic_tau == 70 * 60 * 60);

features/FEATURE_BLE/source/generic/GenericSecurityManager.tpp

@@ -883,9 +883,8 @@ ble_error_t GenericSecurityManager<TPalSecurityManager, SigningMonitor>::init_si
     const csrk_t *pcsrk = _db->get_local_csrk();
     sign_count_t local_sign_counter = _db->get_local_sign_counter();
 
+    csrk_t csrk;
     if (!pcsrk) {
-        csrk_t csrk;
-
         ble_error_t ret = get_random_data(csrk.data(), csrk.size());
         if (ret != BLE_ERROR_NONE) {
             return ret;

features/cellular/framework/AT/AT_CellularNetwork.cpp

@@ -177,6 +177,7 @@ void AT_CellularNetwork::read_reg_params_and_compare(RegistrationType type)
         }
         if (reg_params._cell_id != -1 && reg_params._cell_id != _reg_params._cell_id) {
             _reg_params._cell_id = reg_params._cell_id;
+            _reg_params._lac = reg_params._lac;
             data.status_data = reg_params._cell_id;
             _connection_status_cb((nsapi_event_t)CellularCellIDChanged, (intptr_t)&data);
         }

features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp

@@ -190,7 +190,7 @@ nsapi_size_or_error_t QUECTEL_BC95_CellularStack::socket_sendto_impl(CellularSoc
         _at.write_int(socket->id);
         _at.write_int(size);
     } else {
-        delete hexstr;
+        delete [] hexstr;
         return NSAPI_ERROR_PARAMETER;
     }
 
@@ -202,7 +202,7 @@ nsapi_size_or_error_t QUECTEL_BC95_CellularStack::socket_sendto_impl(CellularSoc
     sent_len = _at.read_int();
     _at.resp_stop();
 
-    delete hexstr;
+    delete [] hexstr;
 
     if (_at.get_last_error() == NSAPI_ERROR_OK) {
         return sent_len;

features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp

@@ -20,6 +20,7 @@
 #include "QUECTEL_BG96_CellularStack.h"
 #include "QUECTEL_BG96_CellularInformation.h"
 #include "QUECTEL_BG96_CellularContext.h"
+#include "CellularLog.h"
 
 using namespace mbed;
 using namespace events;

targets/TARGET_Atmel/TARGET_SAM_CortexM0P/TARGET_SAML21J18A/analogout_api.c

@@ -21,6 +21,8 @@
 #include "PeripheralPins.h"
 #include "dac.h"
 
+#if DEVICE_ANALOGOUT
+
 extern uint8_t g_sys_init;
 
 #define MAX_VAL_12BIT 0x0FFF  /*12 Bit DAC for SAML21*/
@@ -119,4 +121,5 @@ const PinMap *analogout_pinmap()
 {
     return PinMap_DAC;
 }
-#endif
+
+#endif // DEVICE_ANALOGOUT

targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8C62XX/TARGET_MCU_PSOC6_M0/system_psoc6_cm0plus.c

@@ -193,13 +193,6 @@ void mailbox_init(void);
 *******************************************************************************/
 void SystemInit(void)
 {
-    /* Workaround to avoid twice SystemInit() call when ARMC5 compiler is used */
-    static uint32_t temp_var = 0;
-
-    if (temp_var == 0)
-    {
-    temp_var = 1;
-
     Cy_PDL_Init(CY_DEVICE_CFG);
 
     /* Restore FLL registers to the default state as they are not restored by the ROM code */
@@ -299,8 +292,6 @@ void SystemInit(void)
 #else/* !defined(CY_IPC_DEFAULT_CFG_DISABLE) */
     Cy_SemaIpcFlashInit();
 #endif /* !defined(CY_IPC_DEFAULT_CFG_DISABLE) */
-
-    }
 }
 
 

targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8C62XX/device/system_psoc6.h

@@ -539,11 +539,7 @@ extern "C" {
 * \addtogroup group_system_config_system_functions
 * \{
 */
-#if defined(__ARMCC_VERSION)
-    extern void SystemInit(void) __attribute__((constructor));
-#else
-    extern void SystemInit(void);
-#endif /* (__ARMCC_VERSION) */
+extern void SystemInit(void);
 
 extern void SystemCoreClockUpdate(void);
 /** \} group_system_config_system_functions */

targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_062_4343W/device/system_psoc6.h

@@ -539,11 +539,7 @@ extern "C" {
 * \addtogroup group_system_config_system_functions
 * \{
 */
-#if defined(__ARMCC_VERSION)
-    extern void SystemInit(void) __attribute__((constructor));
-#else
-    extern void SystemInit(void);
-#endif /* (__ARMCC_VERSION) */
+extern void SystemInit(void);
 
 extern void SystemCoreClockUpdate(void);
 /** \} group_system_config_system_functions */