Skip to content

Commit c60b11e

Browse files
authored
Remove assert-news from pre-commit checks (#56)
The `assert-news` with option `-l` is designed with an assumption that there will only be one commit per PR, therefore it expects a newsfile for every commit which is incorrect. A newsfile is expected per PR. Therefore removing `assert-news` from pre-commit checks. CI will still run `assert-news` on every PR and will fail if newsfile is missing in the PR. Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
1 parent b489ea0 commit c60b11e

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

.pre-commit-config.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
- repo: local
22
hooks:
3-
- id: assertnews
4-
name: news file
5-
entry: assert-news -l
6-
language: python
7-
types: [file]
8-
require_serial: true
9-
verbose: true
10-
always_run: true
11-
pass_filenames: false
12-
133
- id: licensing
144
name: licensing
155
entry: license-files

news/2020070701.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove from pre-commit checks

0 commit comments

Comments
 (0)