Skip to content

Commit 988d8e6

Browse files
🐛 subprocess Make sure that newSubProcess supports overriding the stdin, stdout, and stderr (#708)
<!-- Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors. All rights reserved. SPDX-License-Identifier: Apache-2.0 --> ### Description <!-- Please add any detail or context that would be useful to a reviewer. --> Make sure that newSubProcess supports overriding the stdin, stdout, and stderr ### Test Coverage <!-- Please put an `x` in the correct box e.g. `[x]` to indicate the testing coverage of this change. --> - [x] This change is covered by existing or additional automated tests. - [ ] Manual testing has been performed (and evidence provided) as automated testing was not feasible. - [ ] Additional tests are not required for this change (e.g. documentation update).
1 parent ef06f66 commit 988d8e6

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

changes/20250911152014.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
:bug: `subprocess` Make sure that newSubProcess supports overriding the stdin, stdout, and stderr

utils/subprocess/executor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func NewWithEnvironmentWithIO(ctx context.Context, loggers logs.Loggers, io ICom
5151
// newSubProcess creates a subprocess description with custom IO
5252
func newSubProcess(ctx context.Context, loggers logs.Loggers, io ICommandIO, env []string, messageOnStart string, messageOnSuccess, messageOnFailure string, as *commandUtils.CommandAsDifferentUser, cmd string, args ...string) (p *Subprocess, err error) {
5353
p = new(Subprocess)
54-
err = p.SetupAsWithEnvironment(ctx, loggers, env, messageOnStart, messageOnSuccess, messageOnFailure, as, cmd, args...)
54+
err = p.SetupAsWithEnvironmentWithCustomIO(ctx, loggers, io, env, messageOnStart, messageOnSuccess, messageOnFailure, as, cmd, args...)
5555
return
5656
}
5757

0 commit comments

Comments
 (0)