Fix a bug in serialization.

Author: braxtonmckee

typed_python/TupleOrListOfType.hpp

@@ -17,6 +17,7 @@
 #pragma once
 
 #include "Type.hpp"
+#include "Format.hpp"
 
 class TupleOrListOfType : public Type {
 public:
@@ -436,7 +437,7 @@ class TupleOrListOfType : public Type {
 
         buffer.writeUnsignedVarintObject(0, ct);
 
-        if (m_element_type->isPOD() && buffer.getContext().serializePodListsInline()) {
+        if (ct && m_element_type->isPOD() && buffer.getContext().serializePodListsInline()) {
             if (m_element_type->getTypeCategory() == TypeCategory::catInt64) {
                 serializeIntList(
                     (int64_t*)this->eltPtr(self, 0),
@@ -485,7 +486,12 @@ class TupleOrListOfType : public Type {
             if (ptr) {
                 ((layout**)self)[0] = (layout*)ptr;
                 ((layout**)self)[0]->refcount++;
-                buffer.finishCompoundMessage(wireType);
+                try {
+                    buffer.finishCompoundMessage(wireType);
+                } catch(...) {
+                    throw std::runtime_error("1. Failed finishing: " + name());
+                }
+
                 return;
             }
         }
@@ -550,7 +556,13 @@ class TupleOrListOfType : public Type {
             }
         }
 
-        buffer.finishCompoundMessage(wireType);
+        try {
+            buffer.finishCompoundMessage(wireType);
+        }
+        catch(...) {
+            throw std::runtime_error("2. Failed finishing: " + name() + ": " + format(ct));
+        }
+
     }
 
 protected:

typed_python/types_serialization_test.py

@@ -364,6 +364,12 @@ def check_idempotence(x):
         check_idempotence(ListOf(int)([1, 2, 3] * 1000 + [11111111111111] + [1, 2, 3] * 1000))
         check_idempotence(ListOf(float)(range(100)))
 
+        aList = ListOf(float)(range(100))
+        check_idempotence((aList, aList))
+
+        aList.resize(0)
+        check_idempotence((aList, aList))
+
     def test_serialize_lists_compression_and_threads(self):
         someFloats = ListOf(float)(range(1000000))
         for _ in range(6):