Merge pull request #170 from stoplightio/fix/no-plugin-result

Throw when no plugin returned a result

Author: philsturgeon

lib/util/plugins.js

@@ -84,7 +84,9 @@ exports.run = function (plugins, method, file, $refs) {
           // A synchronous result was returned
           onSuccess(result);
         }
-        // else { the callback will be called }
+        else if (index === plugins.length) {
+          throw new Error("No promise has been returned or callback has been called.");
+        }
       }
       catch (e) {
         onError(e);

test/specs/parsers/parsers.spec.js

@@ -68,7 +68,7 @@ describe("References to non-JSON files", () => {
     expect(schema).to.deep.equal(dereferencedSchema.binaryParser);
   });
 
-  it("should throw an error if no no parser can be matched", async () => {
+  it("should throw an error if no parser can be matched", async () => {
     try {
       await $RefParser.dereference(path.rel("specs/parsers/parsers.yaml"), {
         parse: {
@@ -78,6 +78,7 @@ describe("References to non-JSON files", () => {
           binary: false,
         },
       });
+      helper.shouldNotGetCalled();
     }
     catch (err) {
       expect(err).to.be.an.instanceOf(SyntaxError);
@@ -86,6 +87,29 @@ describe("References to non-JSON files", () => {
     }
   });
 
+  it("should throw an error if no parser returned a result", async () => {
+    try {
+      await $RefParser.dereference(path.rel("specs/parsers/parsers.yaml"), {
+        parse: {
+          yaml: {
+            canParse: true,
+            parse () {
+            }
+          },
+          json: false,
+          text: false,
+          binary: false,
+        },
+      });
+      helper.shouldNotGetCalled();
+    }
+    catch (err) {
+      // would time out otherwise
+      expect(err).to.be.an.instanceOf(ParserError);
+      expect(err.message).to.contain("No promise has been returned or callback has been called.");
+    }
+  });
+
   it('should throw an error if "parse.text" and "parse.binary" are disabled', async () => {
     try {
       await $RefParser.dereference(path.rel("specs/parsers/parsers.yaml"), { parse: { text: false, binary: false }});

test/specs/resolvers/resolvers.spec.js

@@ -137,6 +137,28 @@ describe("options.resolve", () => {
     }
   });
 
+  it("should throw an error if no resolver returned a result", async () => {
+    try {
+      await $RefParser.dereference(path.rel("specs/resolvers/resolvers.yaml"), {
+        resolve: {
+          http: false,
+          file: {
+            order: 1,
+            canRead: true,
+            read () {
+
+            }
+          }
+        }
+      });
+      helper.shouldNotGetCalled();
+    }
+    catch (err) {
+      // would time out otherwise
+      expect(err).to.be.an.instanceOf(ResolverError);
+    }
+  });
+
   it("should throw a grouped error if no resolver can be matched and fastFail is false", async () => {
     const parser = new $RefParser();
     try {