Merge pull request #197 from mathieudutour/patch-1

add stripQuery method and strip the query from the extension

Author: philsturgeon

lib/util/url.js

@@ -69,11 +69,25 @@ exports.getProtocol = function getProtocol (path) {
 exports.getExtension = function getExtension (path) {
   let lastDot = path.lastIndexOf(".");
   if (lastDot >= 0) {
-    return path.substr(lastDot).toLowerCase();
+    return url.stripQuery(path.substr(lastDot).toLowerCase());
   }
   return "";
 };
 
+/**
+ * Removes the query, if any, from the given path.
+ *
+ * @param   {string} path
+ * @returns {string}
+ */
+exports.stripQuery = function stripQuery (path) {
+  let queryIndex = path.indexOf("?");
+  if (queryIndex >= 0) {
+    path = path.substr(0, queryIndex);
+  }
+  return path;
+};
+
 /**
  * Returns the hash (URL fragment), of the given path.
  * If there is no hash, then the root hash ("#") is returned.

test/specs/util/url.spec.js

@@ -0,0 +1,24 @@
+"use strict";
+
+const chai = require("chai");
+const chaiSubset = require("chai-subset");
+chai.use(chaiSubset);
+const { expect } = chai;
+const $url = require("../../../lib/util/url");
+
+describe("Return the extension of a URL", () => {
+  it("should return an empty string if there isn't any extension", async () => {
+    const extension = $url.getExtension("/file");
+    expect(extension).to.equal("");
+  });
+
+  it("should return the extension in lowercase", async () => {
+    const extension = $url.getExtension("/file.YML");
+    expect(extension).to.equal(".yml");
+  });
+
+  it("should return the extension without the query", async () => {
+    const extension = $url.getExtension("/file.yml?foo=bar");
+    expect(extension).to.equal(".yml");
+  });
+});