Moved pagination of Criteria after the event

Author: TomHAnderson

docs/events.rst

@@ -79,6 +79,12 @@ When an association is resolved from an entity or another association, you may
 listen to the Criteria Event to add additional criteria for filtering
 the association if you assigned an event name in the attributes.
 
+Note that pagination limits are not applied to the Collection before this event
+is fired.  That way you can add additional criteria to the Collection before
+the limit is applied.  This is done by fetching the collection within the event
+and running additional filters on each element.  This is not the most efficient
+way to filter data, but it is the most flexible.
+
 .. code-block:: php
 
   use ApiSkeletons\Doctrine\ORM\GraphQL\Attribute as GraphQL;

src/Event/Criteria.php

@@ -22,8 +22,8 @@ class Criteria implements
      * @param mixed[]                                $args
      */
     public function __construct(
-        protected readonly DoctrineCriteria $criteria,
         protected readonly string $eventName,
+        protected readonly DoctrineCriteria $criteria,
         protected readonly Collection $collection,
         protected readonly mixed $objectValue,
         protected readonly array $args,

src/Resolve/ResolveCollectionFactory.php

@@ -151,29 +151,30 @@ protected function buildPagination(
 
         $itemCount = count($collection->matching($criteria));
 
-        $offsetAndLimit = $this->calculateOffsetAndLimit($resolve[3]->fieldName, $entityClassName, $targetClassName, $paginationFields, $itemCount);
-        if ($offsetAndLimit['offset']) {
-            $criteria->setFirstResult($offsetAndLimit['offset']);
-        }
-
-        if ($offsetAndLimit['limit']) {
-            $criteria->setMaxResults($offsetAndLimit['limit']);
-        }
-
         /**
          * Fire the event dispatcher using the passed event name.
          */
         if ($criteriaEventName) {
             $this->eventDispatcher->dispatch(
                 new CriteriaEvent(
-                    $criteria,
                     $criteriaEventName,
+                    $criteria,
                     $collection,
                     ...$resolve,
                 ),
             );
         }
 
+        // Add offset and limit after Criteria event
+        $offsetAndLimit = $this->calculateOffsetAndLimit($resolve[3]->fieldName, $entityClassName, $targetClassName, $paginationFields, $itemCount);
+        if ($offsetAndLimit['offset']) {
+            $criteria->setFirstResult($offsetAndLimit['offset']);
+        }
+
+        if ($offsetAndLimit['limit']) {
+            $criteria->setMaxResults($offsetAndLimit['limit']);
+        }
+
         $edgesAndCursors = $this->buildEdgesAndCursors($collection->matching($criteria), $offsetAndLimit, $itemCount);
 
         // Return entities