Clean Tests & Includes (#211)

Issues seen with `pyflakes` and `ruff`.

Author: ax3l

src/amrex/ArrayOfStructs.py

@@ -5,7 +5,6 @@
 Authors: Axel Huebl
 License: BSD-3-Clause-LBNL
 """
-from collections import namedtuple
 
 
 def aos_to_numpy(self, copy=False):
@@ -65,10 +64,6 @@ def aos_to_cupy(self, copy=False):
     """
     import cupy as cp
 
-    SoA_cp = namedtuple(type(self).__name__ + "_cp", ["real", "int"])
-
-    soa_view = SoA_cp([], [])
-
     if self.size() == 0:
         raise ValueError("AoS is empty.")
 

src/amrex/StructOfArrays.py

@@ -25,8 +25,6 @@ def soa_to_numpy(self, copy=False):
         A tuple with real and int components that are each lists
         of 1D numpy arrays.
     """
-    import numpy as np
-
     SoA_np = namedtuple(type(self).__name__ + "_np", ["real", "int"])
 
     soa_view = SoA_np([], [])
@@ -65,8 +63,6 @@ def soa_to_cupy(self, copy=False):
     ImportError
         Raises an exception if cupy is not installed
     """
-    import cupy as cp
-
     SoA_cp = namedtuple(type(self).__name__ + "_cp", ["real", "int"])
 
     soa_view = SoA_cp([], [])

src/amrex/space1d/__init__.py

@@ -37,10 +37,10 @@ def d_decl(x, y, z):
 
 def Print(*args, **kwargs):
     """Wrap amrex::Print() - only the IO processor writes"""
-    if not initialized():
+    if not initialized():  # noqa
         print("warning: Print all - AMReX not initialized")
         print(*args, **kwargs)
-    elif ParallelDescriptor.IOProcessor():
+    elif ParallelDescriptor.IOProcessor():  # noqa
         print(*args, **kwargs)
 
 

src/amrex/space2d/__init__.py

@@ -37,10 +37,10 @@ def d_decl(x, y, z):
 
 def Print(*args, **kwargs):
     """Wrap amrex::Print() - only the IO processor writes"""
-    if not initialized():
+    if not initialized():  # noqa
         print("warning: Print all - AMReX not initialized")
         print(*args, **kwargs)
-    elif ParallelDescriptor.IOProcessor():
+    elif ParallelDescriptor.IOProcessor():  # noqa
         print(*args, **kwargs)
 
 

src/amrex/space3d/__init__.py

@@ -37,10 +37,10 @@ def d_decl(x, y, z):
 
 def Print(*args, **kwargs):
     """Wrap amrex::Print() - only the IO processor writes"""
-    if not initialized():
+    if not initialized():  # noqa
         print("warning: Print all - AMReX not initialized")
         print(*args, **kwargs)
-    elif ParallelDescriptor.IOProcessor():
+    elif ParallelDescriptor.IOProcessor():  # noqa
         print(*args, **kwargs)
 
 

tests/conftest.py

@@ -16,8 +16,9 @@
         except ImportError:
             raise ImportError("AMReX: No 1D, 2D or 3D module found!")
 
+# Import calls MPI_Initialize, if not called already
 if amr.Config.have_mpi:
-    from mpi4py import MPI
+    from mpi4py import MPI  # noqa
 
 # base path for input files
 basepath = os.getcwd()

tests/test_aos.py

@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 
 import numpy as np
-import pytest
 
 import amrex.space3d as amr
 
@@ -85,6 +84,9 @@ def test_array_interface():
     print(arr)
     print(aos[0], aos[1])
     print("-------")
+    aos[0] = p4
+    assert aos[0].x == 0
+    assert aos[0].y == -5
     aos[0] = p3
     print("array:", arr)
     print("aos[0]:", aos[0], "aos[1]:", aos[1])

tests/test_array4.py

@@ -87,8 +87,10 @@ def test_array4_numba():
     )  # type: numpy.ndarray
 
     # host-to-device copy
-    x_numba = cuda.to_device(x)  # type: numba.cuda.cudadrv.devicearray.DeviceNDArray
-    # x_cupy = cupy.asarray(x_numba)      # type: cupy.ndarray
+    x_numba = cuda.to_device(x)  # noqa
+    #   type is numba.cuda.cudadrv.devicearray.DeviceNDArray
+    # x_cupy = cupy.asarray(x_numba)
+    #   type is cupy.ndarray
 
     # TODO: Implement __cuda_array_interface__ or DLPack in Array4 constructor
     # x_arr = amr.Array4_double(x_numba)  # type: amr.Array4_double

tests/test_basefab.py

@@ -6,7 +6,7 @@
 
 
 def test_basefab():
-    bf = amr.BaseFab_Real()
+    bf = amr.BaseFab_Real()  # noqa
 
 
 def test_basefab_to_host():

tests/test_coordsys.py

@@ -1,8 +1,5 @@
 # -*- coding: utf-8 -*-
 
-import numpy as np
-import pytest
-
 import amrex.space3d as amr
 
 # import amrex.space3d as amr.CoordSys.CoordType as CoordType