Temporarily remove profiler (de)activation metric logging #2638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new config
hide_profiler_step_metricto omit metric logging for profiler start/stop and subsequent steps.This change temporarily removes metric logging for four specific steps:
These steps produce outlier timings because profiler activation/deactivation overhead is currently included in the step time, which skews MFU and other benchmark metrics. This is a short-term fix to address the benchmarking inaccuracies described in b/456828037.
A long-term solution, moving the profiler to a separate subprocess to isolate its overhead, is planned.
Tests
smoke_train skip_first_n_steps_for_profiler=10 profiler_steps=3 profiler=xplane steps=20The log difference can be viewed here: https://diff.googleplex.com/#key=JIA9QUANVfdW
smoke_train skip_first_n_steps_for_profiler=10 profiler_steps=3 profiler=xplane steps=20 hide_profiler_step_metric=trueThe log difference can be viewed here: https://diff.googleplex.com/#key=LbBZkoUsDAW5
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.