Skip to content

Commit ff9b157

Browse files
committed
Add integration tests with Pathways backend
1 parent b8fb668 commit ff9b157

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

.github/workflows/RunTests.yml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,19 @@ jobs:
121121
container_resource_option: "--privileged"
122122
is_scheduled_run: ${{ github.event_name == 'schedule' }}
123123

124+
tpu_pathways_integration_tests:
125+
needs: tpu_image
126+
uses: ./.github/workflows/run_pathways_tests_internal.yml
127+
with:
128+
device_type: tpu
129+
device_name: v4-8
130+
cloud_runner: linux-x86-ct4p-240-4tpu
131+
pytest_marker: 'not cpu_only and not gpu_only and integration_test'
132+
xla_python_client_mem_fraction: 0.75
133+
tf_force_gpu_allow_growth: false
134+
container_resource_option: "--privileged"
135+
is_scheduled_run: ${{ github.event_name == 'schedule' }}
136+
124137
gpu_unit_tests:
125138
needs: gpu_image
126139
uses: ./.github/workflows/run_tests_internal.yml
@@ -151,7 +164,7 @@ jobs:
151164

152165
clean_up:
153166
if: ${{ always() }}
154-
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests]
167+
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests, tpu_pathways_integration_tests]
155168
name: "Clean up"
156169
runs-on: ["self-hosted"]
157170
permissions:
@@ -170,7 +183,7 @@ jobs:
170183

171184
notify_failure:
172185
name: Notify failed build # creates an issue or modifies last open existing issue for failed build
173-
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests]
186+
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests, tpu_pathways_integration_tests]
174187
if: ${{ always() }}
175188
runs-on: ubuntu-latest
176189
permissions:
@@ -202,7 +215,7 @@ jobs:
202215
name: Close issue after 3 successful builds
203216
# This job runs only if all the preceding test jobs succeeded
204217
if: ${{ success() && github.event.pull_request == null && github.event_name != 'workflow_dispatch' }}
205-
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests]
218+
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests, tpu_pathways_unit_tests, tpu_pathways_integration_tests]
206219
runs-on: ubuntu-latest
207220
permissions:
208221
issues: write

.github/workflows/run_pathways_tests_internal.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ jobs:
6464
IFRT_PROXY_USE_INSECURE_GRPC_CREDENTIALS: true
6565
JAX_PLATFORMS: "proxy"
6666
JAX_BACKEND_TARGET: "grpc://localhost:29000"
67+
# JAX_COORDINATOR_ADDRESS: "localhost"
68+
# JAX_PROCESS_COUNT: "1"
69+
# JAX_PROECESS_ID: "0"
6770
options: ${{ inputs.container_resource_option }}
6871
steps:
6972
- uses: actions/checkout@v4
@@ -77,6 +80,7 @@ jobs:
7780
python3 -m pip install -e . --no-dependencies &&
7881
python3 -m pip uninstall -y libtpu &&
7982
# TODO(b/454659463): Enable test_default_hlo_match after volume mount is supported.
83+
mpirun -n 8 --allow-run-as-root \
8084
python3 -m pytest ${{ inputs.pytest_addopts }} -v -m "${FINAL_PYTEST_MARKER}" -k "not test_default_hlo_match" --durations=0
8185
8286
services:

0 commit comments

Comments
 (0)