fix: timeout in startup tests

Author: Chris Armstrong

test/indexTest.js

@@ -10,18 +10,55 @@ const Plugin = require("../index.js");
 
 const serverlessMock = require("./serverlessMock");
 
+function get(url) {
+  return new Promise(function(resolve, reject) {
+    http.get(url, function(incoming) {
+      resolve(incoming);
+    }).on('error', reject);
+  });
+}
+
+function getWithRetry(url, retryCount, previousError) {
+  retryCount = retryCount || 0;
+  if (retryCount >= 3) {
+    return Promise.reject('Exceeded retry count for get of ' + url, previousError);
+  }
+  return get(url)
+    .catch(function(error) {
+      console.error('error getting ' + url + ', retrying');
+      return new Promise(function(resolve) { setTimeout(resolve, 1000); })
+        .then(function() {
+          return getWithRetry(url, retryCount + 1, error);
+        });
+    });
+}
+
 describe("Port function",function(){
+  let service;
+  before(function(){
+    this.timeout(60000);
+    service = new Plugin(serverlessMock, { stage: 'test' });
+    return service.installHandler();
+  })
+
   it("Port should return number",function(){
-    let service = new Plugin(serverlessMock, {});
     assert(typeof service.port, "number");
   });
 
-  it("Port value should be >= 0 and < 65536",function(done){
-    let service = new Plugin(serverlessMock, {});
-    http.get(`http://localhost:${service.port}/shell/`, function (response) {
-      assert.equal(response.statusCode, 200);
-      done();
-    });
+  it("Port value should be >= 0 and < 65536",function() {
+    this.timeout(10000);
+    return service.startHandler()
+      .then(function() {
+        console.log('started handler');
+        return getWithRetry(`http://localhost:${service.port}/shell/`);
+      })
+      .then(function(response){
+        assert.equal(response.statusCode, 200);
+      });
+  });
+
+  after(function(){
+    return service.endHandler();
   });
 });
 
@@ -41,7 +78,7 @@ describe("Check the dynamodb function",function(){
     let raw = new aws.DynamoDB(dynamoOptions);
     raw.should.be.type("object");
   });
-  
+
   it("Should be an object",function(){
     let dynamoOptions =  Plugin.prototype.dynamodbOptions;
     let doc = new aws.DynamoDB(dynamoOptions);
@@ -62,7 +99,7 @@ describe ("createTable functon",function(){
     const tbl = Plugin.prototype.createTable;
     assert.equal(typeof tbl, "function");
   });
-}); 
+});
 
 describe ("Check the Seeder file",function(){
   it("Table name shoud be a string",function(){

test/serverlessMock.js

@@ -1,7 +1,13 @@
 module.exports = {
-    service: {},
+    service: {
+        custom: {
+            dynamodb: {
+                stages: ['test']
+            }
+        }
+    },
     cli: {
-        log: () => {}
+        log: (...args) => { console.log(...args); }
     },
-    custom: {}
+    custom: {},
 };