More tests.

Author: 5cript

interval_tree.hpp

@@ -177,6 +177,15 @@ namespace lib_interval_tree
         value_type low_;
         value_type high_;
     };
+//############################################################################################################
+    /**
+     *  Creates a safe interval that puts the lower bound left automatically.
+     */
+    template <typename numerical_type, typename interval_kind_ = closed>
+    interval <numerical_type, interval_kind_> make_safe_interval(numerical_type lhs, numerical_type rhs)
+    {
+        return interval <numerical_type, interval_kind_>{std::min(lhs, rhs), std::max(lhs, rhs)};
+    }
 //############################################################################################################
     template <typename numerical_type = default_interval_value_type, typename interval_type_ = interval <numerical_type, closed>>
     class node
@@ -233,6 +242,18 @@ namespace lib_interval_tree
             return !parent_;
         }
 
+        /**
+         *  Returns the height of the node in the tree. Where height = how many parents does it have.
+         *  The root has no parents and is therefor has height 0.
+         */
+        int height() const
+        {
+            int counter{0};
+            for (auto* p = parent_; p != nullptr; p = p->parent_)
+                ++counter;
+            return counter;
+        }
+
 private:
         void set_interval(interval_type const& ival)
         {

tests/insert_tests.hpp

@@ -1,3 +1,7 @@
+#include <ctime>
+#include <random>
+#include <cmath>
+
 class InsertTests
     : public ::testing::Test
 {
@@ -6,6 +10,8 @@ class InsertTests
 
 protected:
     lib_interval_tree::interval_tree <int> tree;
+    std::default_random_engine gen;
+    std::uniform_int_distribution <int> dist{-500, 500};
 };
 
 TEST_F(InsertTests, InsertIntoEmpty1)
@@ -39,3 +45,17 @@ TEST_F(InsertTests, InsertMultipleIntoEmpty)
     EXPECT_EQ(*tree.begin(), firstInterval);
     EXPECT_EQ(*(++tree.begin()), secondInterval);
 }
+
+TEST_F(InsertTests, TreeHeightHealthynessTest)
+{
+    const int amount = 1'000'000;
+
+    for (int i = 0; i != amount; ++i)
+        tree.insert(lib_interval_tree::make_safe_interval(dist(gen), dist(gen)));
+
+    auto maxHeight{0};
+    for (auto i = std::begin(tree); i != std::end(tree); ++i)
+        maxHeight = std::max(maxHeight, i->height());
+
+    EXPECT_LE(maxHeight, 2 * std::log2(amount + 1));
+}

tests/interval_tests.hpp

@@ -34,7 +34,7 @@ class DistanceTests
 
 TEST_F(IntervalTests, FailBadBorders)
 {
-    ASSERT_DEATH(({
+    EXPECT_DEATH(({
         [[maybe_unused]] auto ival = types::interval_type{1 BOOST_PP_COMMA() 0};
     }), "low <= high");
 }