Skip to content

Commit 09fb81a

Browse files
AdminCrystal2shady4u
authored andcommitted
Improve performance by removing pop_front
1 parent ab95d88 commit 09fb81a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/gdsqlite.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ bool SQLite::query_with_bindings(const String &p_query, Array param_bindings) {
248248

249249
/* Bind any given parameters to the prepared statement */
250250
for (int i = 0; i < parameter_count; i++) {
251-
Variant binding_value = param_bindings.pop_front();
251+
Variant binding_value = param_bindings.get(i);
252252
switch (binding_value.get_type()) {
253253
case Variant::NIL:
254254
sqlite3_bind_null(stmt, i + 1);
@@ -291,6 +291,7 @@ bool SQLite::query_with_bindings(const String &p_query, Array param_bindings) {
291291
return false;
292292
}
293293
}
294+
param_bindings = param_bindings.slice(parameter_count, param_bindings.size());
294295

295296
if (verbosity_level > VerbosityLevel::NORMAL) {
296297
char *expanded_sql = sqlite3_expanded_sql(stmt);

0 commit comments

Comments
 (0)