feat: added test controller and exception validation

Author: 1EVILGUN1

.idea/misc.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="AmplicodePersistenceUnitSettings">
+    <persistence-units>
+      <persistence-unit moduleName="service" name="Default">
+        <packages>
+          <package value="service.task.manager" />
+        </packages>
+      </persistence-unit>
+    </persistence-units>
+  </component>
+</project>

amplicode.xml

@@ -60,7 +60,8 @@ public ResponseEntity<EpicResponseDto> update(@RequestBody @Valid EpicRequestUpd
             @ApiResponse(responseCode = "404", description = "Epic not found")
     })
     public ResponseEntity<EpicResponseDto> findById(
-            @Parameter(description = "ID of the epic to retrieve") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the epic to retrieve") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Fetching epic with ID: {}", id);
         EpicResponseDto epic = service.findById(id);
         return ResponseEntity.ok(epic);
@@ -82,7 +83,8 @@ public ResponseEntity<List<EpicResponseDto>> findAll() {
             @ApiResponse(responseCode = "404", description = "Epic not found")
     })
     public ResponseEntity<Void> delete(
-            @Parameter(description = "ID of the epic to delete") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the epic to delete") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Deleting epic with ID: {}", id);
         service.delete(id);
         return ResponseEntity.noContent().build();

service/src/main/java/service/task/manager/controller/EpicController.java

@@ -61,7 +61,8 @@ public ResponseEntity<SubtaskResponseDto> update(@RequestBody @Valid SubtaskRequ
             @ApiResponse(responseCode = "404", description = "Subtask not found")
     })
     public ResponseEntity<SubtaskResponseDto> findById(
-            @Parameter(description = "ID of the subtask to retrieve") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the subtask to retrieve") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Fetching subtask with ID: {}", id);
         SubtaskResponseDto subtask = service.findById(id);
         return ResponseEntity.ok(subtask);
@@ -83,7 +84,8 @@ public ResponseEntity<List<SubtaskResponseDto>> findAll() {
             @ApiResponse(responseCode = "404", description = "Subtask not found")
     })
     public ResponseEntity<Void> delete(
-            @Parameter(description = "ID of the subtask to delete") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the subtask to delete") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Deleting subtask with ID: {}", id);
         service.delete(id);
         return ResponseEntity.noContent().build();

service/src/main/java/service/task/manager/controller/SubtaskController.java

@@ -60,7 +60,8 @@ public ResponseEntity<TaskResponseDto> update(@RequestBody @Valid TaskRequestUpd
             @ApiResponse(responseCode = "404", description = "Task not found")
     })
     public ResponseEntity<TaskResponseDto> get(
-            @Parameter(description = "ID of the task to retrieve") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the task to retrieve") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Fetching task with ID: {}", id);
         TaskResponseDto task = service.findById(id);
         return ResponseEntity.ok(task);
@@ -82,7 +83,8 @@ public ResponseEntity<List<TaskResponseDto>> getAll() {
             @ApiResponse(responseCode = "404", description = "Task not found")
     })
     public ResponseEntity<Void> delete(
-            @Parameter(description = "ID of the task to delete") @PathVariable @Positive @NotNull Long id) {
+            @Parameter(description = "ID of the task to delete") @PathVariable @Positive(message = "id must be positive")
+            @NotNull(message = "null id") Long id) {
         log.info("Deleting task with ID: {}", id);
         service.delete(id);
         return ResponseEntity.noContent().build();

service/src/main/java/service/task/manager/controller/TaskController.java

@@ -1,9 +1,19 @@
 package service.task.manager.error;
 
+import jakarta.validation.ConstraintViolation;
+import jakarta.validation.ConstraintViolationException;
+import org.springframework.context.MessageSourceResolvable;
 import org.springframework.http.HttpStatus;
+import org.springframework.validation.FieldError;
+import org.springframework.validation.ObjectError;
+import org.springframework.web.bind.MethodArgumentNotValidException;
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.ResponseStatus;
 import org.springframework.web.bind.annotation.RestControllerAdvice;
+import org.springframework.web.method.annotation.HandlerMethodValidationException;
+
+import java.util.HashMap;
+import java.util.Map;
 
 @RestControllerAdvice
 public class ErrorHandler {
@@ -32,7 +42,47 @@ public ErrorResponse handleConflictException(ConflictException ex) {
         return new ErrorResponse(ex.getMessage());
     }
 
-    record ErrorResponse(String message) {
+    @ExceptionHandler(MethodArgumentNotValidException.class)
+    @ResponseStatus(HttpStatus.BAD_REQUEST)
+    public Map<String, String> handleMethodArgumentNotValidException(MethodArgumentNotValidException ex) {
+        Map<String, String> errors = new HashMap<>();
+        for (FieldError error : ex.getBindingResult().getFieldErrors()) {
+            errors.put(error.getField(), error.getDefaultMessage());
+        }
+        return errors;
+    }
+
+    @ExceptionHandler(ConstraintViolationException.class)
+    @ResponseStatus(HttpStatus.BAD_REQUEST)
+    public Map<String, String> handleConstraintViolationException(ConstraintViolationException ex) {
+        Map<String, String> errors = new HashMap<>();
+        for (ConstraintViolation<?> violation : ex.getConstraintViolations()) {
+            String fieldName = violation.getPropertyPath().toString();
+            fieldName = fieldName.substring(fieldName.lastIndexOf('.') + 1);
+            errors.put(fieldName, violation.getMessage());
+        }
+        return errors;
     }
 
-}
+    @ExceptionHandler(HandlerMethodValidationException.class)
+    @ResponseStatus(HttpStatus.BAD_REQUEST)
+    public Map<String, String> handleHandlerMethodValidationException(HandlerMethodValidationException ex) {
+        Map<String, String> errors = new HashMap<>();
+        for (MessageSourceResolvable resolvable : ex.getAllErrors()) {
+            if (resolvable instanceof FieldError fieldError) {
+                errors.put(fieldError.getField(), fieldError.getDefaultMessage());
+            } else if (resolvable instanceof ObjectError objectError) {
+                // Для параметров метода (например, @PathVariable)
+                String paramName = objectError.getObjectName();
+                errors.put(paramName, objectError.getDefaultMessage());
+            } else {
+                // Для случаев, когда resolvable не является ObjectError
+                errors.put("error", resolvable.getDefaultMessage());
+            }
+        }
+        return errors;
+    }
+
+    record ErrorResponse(String message) {
+    }
+}