Skip to content

fix: correct typos in comments, variable names, and CLI argument names #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correct typos in comments, variable names, and CLI argument names #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d0ba7
Update main.rs
MozirDmitriy Aug 18, 2025
4bee042
Update packable.rs
MozirDmitriy Aug 18, 2025
2d9111d
Update linearhash_bls12381.rs
MozirDmitriy Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fields/src/packable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::ff::PrimeFieldRepr;
use crate::packed::PackedField;

/// Points us to the default packing for a particular field. There may me multiple choices of
/// Points us to the default packing for a particular field. There may be multiple choices of
/// PackedField for a particular Field (e.g. every Field is also a PackedField), but this is the
/// recommended one. The recommended packing varies by target_arch and target_feature.
pub trait Packable: PrimeFieldRepr {
Expand Down
2 changes: 1 addition & 1 deletion starky/src/linearhash_bls12381.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ impl LinearHashBLS12381 {
let bn_mont = match Fr::from_repr(bn.into_raw_repr()) {
Ok(x) => x,
_ => {
//cornor case: x > MODULUS
//corner case: x > MODULUS
let mut r = Fr(bn.into_raw_repr());
const R2: FrRepr = FrRepr([
14526898881837571181u64,
Expand Down
6 changes: 3 additions & 3 deletions zkit/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ struct GenerateVerifierOpt {
#[arg(short, default_value = "vk.bin")]
vk_file: String,
#[arg(short, default_value = "groth16")]
protocal: String,
protocol: String,
#[arg(short, default_value = "verifier.sol")]
sol: String,
}
Expand Down Expand Up @@ -97,7 +97,7 @@ struct ExportAggregationVerificationKeyOpt {
/// Stark proving and verifying all in one
#[derive(Parser, Debug)]
struct StarkProveOpt {
#[arg(short, long = "stark_stuct", default_value = "stark_struct.json")]
#[arg(short, long = "stark_struct", default_value = "stark_struct.json")]
stark_struct: String,
#[arg(short, long = "piljson", default_value = "pil.json")]
piljson: String,
Expand All @@ -111,7 +111,7 @@ struct StarkProveOpt {
const_pols: String,
#[arg(long = "m", default_value = "pols.cm")]
cm_pols: String,
#[arg(short, long = "circom", default_value = "stark_verfier.circom")]
#[arg(short, long = "circom", default_value = "stark_verifier.circom")]
circom_file: String,
#[arg(long = "i", default_value = "zkin.json")]
zkin: String,
Expand Down